1306261 - "Cause" popup does not use source map (netmonitor)

Status: RESOLVED WONTFIX

(DevTools :: Netmonitor, defect, P2)

Description

[Jens]

STR:
I've enabled "devtools.sourcemap.locations.enabled" to make use of the source maps as fixed in Bug 670002. 

AR:
However, the "cause" popup still shows the *not* sourcemapped files. 

ER:
It should also show the 'original' (sourcemapped) files and file numbers as Cause. This is what's important for me as a developer (same reason as why it's shown like this in the console)

Comment 1

[Jarda Snajdr [:jsnajdr]]

The stack trace popup in Netmonitor should start using the shared StackTrace React component, together with its built-in support for the sourceMapService.

As a prerequisite, support for rendering React components should be added to HTMLTooltip. Right now, it only supports setting a DOM element as the content.

Comment 2

[Jaideep Bhoosreddy [:jbhoosreddy]]

After the prerequisite for rendering React components in HTMLTooltip is resolved, I should be able to make the changes as you suggested.

Comment 3

[Julian Descottes [:jdescottes]]

I opened Bug 1306291 to support loading react components in the HTMLTooltip.

Comment 4

[Tom Tromey :tromey]

Is this bug still relevant?  IIUC it is specific to the old network panel.
I filed bug 1361853 for the new work (but I'm happy to close one or the other
if it makes sense).  Also I'm wondering about bug 1306291, linked from here.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Tom Tromey :tromey from comment #4)
> Is this bug still relevant?  IIUC it is specific to the old network panel.
> I filed bug 1361853 for the new work (but I'm happy to close one or the other
> if it makes sense).  Also I'm wondering about bug 1306291, linked from here.

The Net monitor panel is already using shared StackTrace component (devtools/client/shared/components/stack-trace)
Also, the stack trace is now displayed in a side panel (not in a tooltip) so dependency on Bug 1306291 is no longer relevant.

Bug 1361853 seems to cover the necessary work nicely, so I am closing this one.

Honza