Closed Bug 1361954 Opened 5 years ago Closed 5 years ago

Have an illustration when there are no search results

Categories

(Firefox :: Preferences, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox57 --- verified

People

(Reporter: chsiang, Assigned: rickychien)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-preference])

Attachments

(1 file)

No description provided.
We need the visual spec here.
Blocks: 1357306
No longer blocks: 1357308
Flags: qe-verify+
QA Contact: hani.yacoub
Target Milestone: --- → Firefox 57
hi Tina,

will we have illustration for this one?

thank you very much
Flags: needinfo?(thsieh)
Whiteboard: [photon-preference] → [photon-preference][triage]
We should have that. I'll ask Helen to update visual spec here when our schedule of delivering illustrations is clear.
Flags: needinfo?(thsieh) → needinfo?(hhuang)
Priority: P3 → P2
Whiteboard: [photon-preference][triage] → [photon-preference]
No search result visual spec https://mozilla.invisionapp.com/share/X8BGCX9PD#/screens/245813929
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Flags: needinfo?(hhuang)
Priority: P2 → P1
Comment on attachment 8891918 [details]
Bug 1361954 - Introduce new no search results page for about:preferences

https://reviewboard.mozilla.org/r/162942/#review169904

Great patch, adorable illustration. Thanks!

::: commit-message-7aa62:1
(Diff revision 5)
> +Bug 1361954 - Introduce new no search results page r?mconley

Nit: This should probably specifiy that this is for about:preferences.

::: browser/themes/shared/incontentprefs/preferences.inc.css:730
(Diff revision 5)
>  
>  .menu-iconic-highlightable-text {
>    margin: 0; /* Align with the margin of xul:label.menu-iconic-text */
>  }
> +
> +%ifdef MOZ_PHOTON_PREFERENCES

These can probably go away soon. :)
Attachment #8891918 - Flags: review?(mconley) → review+
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c3671e793ebf
Introduce new no search results page for about:preferences r=mconley
https://hg.mozilla.org/mozilla-central/rev/c3671e793ebf
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Build ID: 20170821100350
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.