1361954 - Have an illustration when there are no search results

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Comment 1

[Evan Tseng [:evanxd]]

We need the visual spec here.

Comment 2

[Francis Lee [:frlee]]

hi Tina,

will we have illustration for this one?

thank you very much

Comment 3

[Tina Hsieh[:Tina_Hsieh] UX]

We should have that. I'll ask Helen to update visual spec here when our schedule of delivering illustrations is clear.

Comment 4

[Ricky Chien [:rickychien] (inactive)]

No search result visual spec https://mozilla.invisionapp.com/share/X8BGCX9PD#/screens/245813929

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1361954 - Introduce new no search results page for about:preferences

Review commit: https://reviewboard.mozilla.org/r/162942/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162942/

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8891918 [details]
Bug 1361954 - Introduce new no search results page for about:preferences

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/162942/diff/1-2/

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8891918 [details]
Bug 1361954 - Introduce new no search results page for about:preferences

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/162942/diff/2-3/

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8891918 [details]
Bug 1361954 - Introduce new no search results page for about:preferences

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/162942/diff/3-4/

Comment 9

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8891918 [details]
Bug 1361954 - Introduce new no search results page for about:preferences

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/162942/diff/4-5/

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8891918 [details]
Bug 1361954 - Introduce new no search results page for about:preferences

https://reviewboard.mozilla.org/r/162942/#review169904

Great patch, adorable illustration. Thanks!

::: commit-message-7aa62:1
(Diff revision 5)
> +Bug 1361954 - Introduce new no search results page r?mconley

Nit: This should probably specifiy that this is for about:preferences.

::: browser/themes/shared/incontentprefs/preferences.inc.css:730
(Diff revision 5)
>  
>  .menu-iconic-highlightable-text {
>    margin: 0; /* Align with the margin of xul:label.menu-iconic-text */
>  }
> +
> +%ifdef MOZ_PHOTON_PREFERENCES

These can probably go away soon. :)

Comment 11

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8891918 [details]
Bug 1361954 - Introduce new no search results page for about:preferences

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/162942/diff/5-6/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3671e793ebf
Introduce new no search results page for about:preferences r=mconley

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c3671e793ebf

Comment 14

[Aki Sasaki (not active)]

https://hg.mozilla.org/projects/date/rev/c3671e793ebfb975ac13f06299cd72a209695231
Bug 1361954 - Introduce new no search results page for about:preferences r=mconley

Comment 15

[Hani Yacoub, Desktop QA]

Build ID: 20170821100350
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.