1362195 - Remove GeckoInterface.setFullScreen

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 1. Add EventDispatcher::Dispatch for C++ code (v1)

Add an EventDispatcher::Dispatch function for C++ code, so native code
can dispatch events to JS/Java.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 2. Add onFullScreen to GeckoView.ContentListener (v1)

Add the onFullScreen method to GeckoView.ContentListener to handle
entering and exiting full screen mode.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 3. Call onFullScreen for full screen changes (v1)

Send an event from nsWindow to GeckoView when we enter/exit full screen
mode, and call ContentListener.onFullScreen to notify the implementer.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 4. Implement onFullScreen for GeckoApp/BrowserApp (v1)

Use a custom ContentListener for GeckoApp/BrowserApp that implements
onFullScreen to set full screen mode for the Activity.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 5. Remove GeckoInterface.setFullScreen (v1)

Remove GeckoInterface.setFullScreen now that it's no longer used. r=me
for trivial patch.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/741e175e254c
1. Add EventDispatcher::Dispatch for C++ code; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/2acf5f4b6943
2. Add onFullScreen to GeckoView.ContentListener; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e8e68c6e3ae
3. Call onFullScreen for full screen changes; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/5eb0e63fde7b
4. Implement onFullScreen for GeckoApp/BrowserApp; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/4dda9c43663e
5. Remove GeckoInterface.setFullScreen; r=me

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ab9ba92e6a4
6. Implement onFullScreen for geckoview_example; r=me

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/741e175e254c
https://hg.mozilla.org/mozilla-central/rev/2acf5f4b6943
https://hg.mozilla.org/mozilla-central/rev/8e8e68c6e3ae
https://hg.mozilla.org/mozilla-central/rev/5eb0e63fde7b
https://hg.mozilla.org/mozilla-central/rev/4dda9c43663e
https://hg.mozilla.org/mozilla-central/rev/6ab9ba92e6a4