1367234 - Make onFullScreen work under e10s

Status: VERIFIED FIXED

(GeckoView Graveyard :: Sandboxing, enhancement)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Right now ContentListener.onFullScreen is not called for GeckoViews with e10s enabled.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Support fullscreen for e10s GeckoView (v1)

Add event listeners and implement basic messages between chrome and
content so let e10s content in GeckoView request/exit fullscreen. Once
we're on the parent side, we still go through the normal fullscreen flow
so there is no platform or Java change involved.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 2. Hide action bar on full screen in geckoview_example (v1)

Hide the action bar on full screen in geckoview_example so the page
content covers the entire screen.

Comment 3

[Dylan Roeh (:droeh) (he/him)]

Comment on attachment 8871044 [details] [diff] [review]
Support fullscreen for e10s GeckoView (v1)

Review of attachment 8871044 [details] [diff] [review]:
-----------------------------------------------------------------

One nit, otherwise looks good.

::: mobile/android/chrome/geckoview/GeckoViewContent.js
@@ +57,5 @@
> +        sendAsyncMessage("GeckoView:DOMFullscreenRequest");
> +        break;
> +      case "MozDOMFullscreen:Entered":
> +      case "MozDOMFullscreen:Exited":
> +        // Ensure that the parent always exits fullscreen when content does.

Can you elaborate on this comment a bit (similar to the comment in tab-content.js, line 822)? It seems opaque at first glance to have MozDOMFullScreen:Entered potentially falling through to send GeckoView:DOMFullScreenExit.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/950464e0d22c
1. Support fullscreen for e10s GeckoView; r=droeh
https://hg.mozilla.org/integration/mozilla-inbound/rev/79e7eed00a41
2. Hide action bar on full screen in geckoview_example; r=droeh

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/950464e0d22c
https://hg.mozilla.org/mozilla-central/rev/79e7eed00a41

Comment 6

[Bogdan Surd, QA [:bsurd, NI]]

Device: Nexus 5 (Android 6.0.1)
Verified this in 55.0b3 by creating the browser.tabs.remote.autostart boolean and setting it to true, the browser performed as expected. Marking as verified.

Comment 7

[Chris Peterson [:cpeterson]]

Moving some e10s bugs to the new GeckoView::Sandboxing component.