Closed
Bug 1362387
Opened 7 years ago
Closed 7 years ago
enable CI tests for Linux DevEdition on mozilla-beta
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla55
People
(Reporter: spacurar, Assigned: spacurar)
References
Details
Attachments
(11 files, 5 obsolete files)
886 bytes,
patch
|
kmoir
:
review+
|
Details | Diff | Splinter Review |
1.45 KB,
patch
|
kmoir
:
review+
|
Details | Diff | Splinter Review |
5.15 KB,
patch
|
kmoir
:
review-
|
Details | Diff | Splinter Review |
7.66 KB,
patch
|
Details | Diff | Splinter Review | |
1.17 MB,
patch
|
Details | Diff | Splinter Review | |
1.85 KB,
patch
|
spacurar
:
review+
|
Details | Diff | Splinter Review |
521 bytes,
patch
|
aselagea
:
review+
|
Details | Diff | Splinter Review |
7.98 KB,
patch
|
Details | Diff | Splinter Review | |
1.54 KB,
patch
|
kmoir
:
review+
|
Details | Diff | Splinter Review |
1.37 KB,
patch
|
Details | Diff | Splinter Review | |
1.39 KB,
patch
|
Details | Diff | Splinter Review |
We need to set up unit tests and talos for Linux DevEdition platform.
Assignee | ||
Comment 1•7 years ago
|
||
I think I need to set tests for both linux x32 and x64. I believe I need to enable talos from buildbot and other tests from taskcluster. Am I right?
Assignee: nobody → spacurar
Flags: needinfo?(kmoir)
Comment 2•7 years ago
|
||
For talos, they can be scheduled via taskcluster but the build jobs need to exist on buildbot so they can be scheduled. This is similar to the linux64-stylo talos tests bug. Let me know if you have questions about this, sometimes it can be a bit tricky. You might will have to transform the name of the tests in taskcluster so it matches the ones on buildbot. Again, this is something we can test on the jamun project branch.
Flags: needinfo?(kmoir)
Updated•7 years ago
|
Component: General Automation → Task Configuration
Product: Release Engineering → Taskcluster
QA Contact: catlee
Assignee | ||
Comment 3•7 years ago
|
||
Added tests for Linux 64 devedition in taskcluster
Attachment #8868181 -
Flags: review?(kmoir)
Assignee | ||
Comment 4•7 years ago
|
||
The diff for adding tests on taskcluster
Assignee | ||
Comment 5•7 years ago
|
||
Added ubuntu64_hw_devedition in puppet
Attachment #8868184 -
Flags: review?(kmoir)
Assignee | ||
Comment 6•7 years ago
|
||
Added linux64-devedition and its slave platform (ubuntu64_hw_devedition) in production-masters.json in tools repo.
Attachment #8868185 -
Flags: review?(kmoir)
Comment 7•7 years ago
|
||
Comment on attachment 8868181 [details] [diff] [review] bug_1362387_tc_test-platforms.patch Wondering if the build-platform should be linux64-devedition-nightly/opt instead since the devedition jobs on jamun run as nightlies. Also, I couldn't get the diff to generate the new jobs when I ran this on jamun.
Comment 8•7 years ago
|
||
Comment on attachment 8868184 [details] [diff] [review] bug_1362387_puppet.patch This patch is looks good. There are also patches needed to enable talos job builder names in buildbot so that the devedition talos jobs can run through the buildbot bridge. The linux64-stylo bug is an example of the work that is required there.
Attachment #8868184 -
Flags: review?(kmoir) → review+
Updated•7 years ago
|
Attachment #8868185 -
Flags: review?(kmoir) → review+
Assignee | ||
Comment 9•7 years ago
|
||
Added linux64-devedition in buildbot configs for jamun
Attachment #8868453 -
Flags: review?(kmoir)
Assignee | ||
Comment 10•7 years ago
|
||
The builder diff for adding linux64-devedition on buildbot for jamun.
Assignee | ||
Comment 11•7 years ago
|
||
Changed the build-platform to linux64-nightly/opt
Attachment #8868181 -
Attachment is obsolete: true
Attachment #8868181 -
Flags: review?(kmoir)
Attachment #8868517 -
Flags: review?(kmoir)
Assignee | ||
Comment 12•7 years ago
|
||
This is the builder diff I made after updating the build-platform to linux64-nightly/opt
Attachment #8868182 -
Attachment is obsolete: true
Attachment #8868518 -
Flags: review?(kmoir)
Assignee | ||
Updated•7 years ago
|
Attachment #8868518 -
Flags: review?(kmoir)
Comment 13•7 years ago
|
||
Comment on attachment 8868517 [details] [diff] [review] bug_1362387_tc_v2_test-platforms.patch Should it be something like this so it runs tests against linux64-devedition-nightly/opt instead of linux64-nightly/opt. Also, I don't see the talos jobs added when I compare before and after the patch, so something needs to be added there. --- a/taskcluster/ci/test/test-platforms.yml +++ b/taskcluster/ci/test/test-platforms.yml @@ -41,16 +41,25 @@ linux64/opt: build-platform: linux64/opt test-sets: - common-tests - web-platform-tests - opt-only-tests - desktop-screenshot-capture - talos - awsy +linux64-devedition/opt: + build-platform: linux64-devedition-nightly/opt + test-sets: + - common-tests + - web-platform-tests + - opt-only-tests + - desktop-screenshot-capture + - talos + - awsy linux64-nightly/opt: build-platform: linux64-nightly/opt test-sets: - common-tests - web-platform-tests - opt-only-tests - desktop-screenshot-capture - talos diff --git a/taskcluster/taskgraph/transforms/job/mozharness_test.py b/taskcluster/taskgraph/transforms/job/mozharness_test.py --- a/taskcluster/taskgraph/transforms/job/mozharness_test.py +++ b/taskcluster/taskgraph/transforms/job/mozharness_test.py @@ -22,16 +22,17 @@ ARTIFACTS = [ ("public/test", "artifacts/"), ("public/test_info/", "build/blobber_upload_dir/"), ] BUILDER_NAME_PREFIX = { 'linux64-pgo': 'Ubuntu VM 12.04 x64', 'linux64': 'Ubuntu VM 12.04 x64', 'linux64-nightly': 'Ubuntu VM 12.04 x64', + 'linux64-devedition-nightly': 'Ubuntu VM 12.04 x64', 'linux64-asan': 'Ubuntu ASAN VM 12.04 x64', 'linux64-ccov': 'Ubuntu Code Coverage VM 12.04 x64', 'linux64-jsdcov': 'Ubuntu Code Coverage VM 12.04 x64', 'linux64-stylo': 'Ubuntu VM 12.04 x64', 'macosx64': 'Rev7 MacOSX Yosemite 10.10.5', 'android-4.3-arm7-api-15': 'Android 4.3 armv7 API 15+', 'android-4.2-x86': 'Android 4.2 x86 Emulator', 'android-4.3-arm7-api-15-gradle': 'Android 4.3 armv7 API 15+',
Attachment #8868517 -
Flags: review?(kmoir) → review-
Comment 14•7 years ago
|
||
Comment on attachment 8868453 [details] [diff] [review] bug_1362387_bb-configs.patch Making progress! We're getting there :-) typo here in the word ubuntu diff --git a/mozilla-tests/production_config.py b/mozilla-tests/production_config.py --- a/mozilla-tests/production_config.py +++ b/mozilla-tests/production_config.py @@ -18,6 +18,7 @@ SLAVES = { 'ubuntu64-asan_vm_lnx_large': {}, 'ubuntu64_hw': {}, 'ubuntu64_hw_stylo': {}, + 'ubutnu64_hw_devedition': {}, 'win64_vm': {}, } If you run checkconfig and ./test-masters.sh on your dev-master it should notify you of these sorts of typos. You will also need treeherder patches for the new talos jobs. See bug 1351420 for an example. You will might need to modify something here https://hg.mozilla.org/integration/mozilla-inbound/file/tip/taskcluster/taskgraph/transforms/job/mozharness_test.py#l422 So the taskcluster name for the job matches the one created in buildbot. The talos builder names in taskcluster and on the buildbot master must have the exact same name. Otherwise, when the job is scheduled through taskcluster, and has a different name in buildbot, there will be a payload exception with the taskcluster job because names don't match. Buildbot bridge just tells the corresponding builder name to run a job, so they have to be the same. let me know if you have questions
Attachment #8868453 -
Flags: review?(kmoir) → review-
Comment 15•7 years ago
|
||
patch I mentioned earlier today in our meeting. We can leave out talos for now while we work on the patches to enable the jobs on buildbot.
Attachment #8868517 -
Attachment is obsolete: true
Attachment #8869225 -
Flags: review?(spacurar)
Assignee | ||
Updated•7 years ago
|
Attachment #8869225 -
Flags: review?(spacurar) → review+
Comment 16•7 years ago
|
||
Sebastian, we'll also need a patch to add linux32 tests.
Flags: needinfo?(spacurar)
Comment 17•7 years ago
|
||
Comment on attachment 8869225 [details] [diff] [review] bug1362387tc.patch Landed on jamun to test https://hg.mozilla.org/projects/jamun/rev/c3d5dc1002044b0b5c4fdc38de4db8a7f70429a7
Comment 18•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=jamun&revision=c3d5dc1002044b0b5c4fdc38de4db8a7f70429a7 Looks like this worked for Linux64 on jamun so we'll need to 1) Write a taskcluster patch for Linux32 tests 2) Land these patches on jamun to test, then inbound (eventually they will be uplifted to beta) 3) Write patches to enable talos via bbb for Linux64 only (we don't run talos tests for Linux32)
Assignee | ||
Comment 19•7 years ago
|
||
Added linux32-devedition in taskcluster.
Flags: needinfo?(spacurar)
Attachment #8869961 -
Flags: review?(kmoir)
Assignee | ||
Comment 20•7 years ago
|
||
Taskcluster diff for adding linux32 devedition tests.
Assignee | ||
Comment 21•7 years ago
|
||
Attachment #8869961 -
Attachment is obsolete: true
Attachment #8869961 -
Flags: review?(kmoir)
Attachment #8869990 -
Flags: review?(aselagea)
Assignee | ||
Comment 22•7 years ago
|
||
Attachment #8869962 -
Attachment is obsolete: true
Updated•7 years ago
|
Attachment #8869990 -
Flags: review?(aselagea) → review+
Comment 23•7 years ago
|
||
Pushed to jamun: https://hg.mozilla.org/projects/jamun/rev/44293893aae54b139118c47c3f771a6b71748d3b
Assignee | ||
Comment 24•7 years ago
|
||
I enabled linux64 and linux32 DevEdition tests on mozilla-inbound.
Attachment #8870366 -
Flags: review?(kmoir)
Comment 25•7 years ago
|
||
Comment on attachment 8870366 [details] [diff] [review] bug_1362387_linux32-64-tc-mozilla-inbound.patch thanks, lgtm I seem the patch is already landed on jamun and tests are running. That's great! I'm not sure if all the build patches for the dev edition builds have landed on inbound, might want to verify that before landing there.
Attachment #8870366 -
Flags: review?(kmoir) → review+
Comment 26•7 years ago
|
||
Comment 27•7 years ago
|
||
Pushed by kmoir@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8140b96e2c0d enable CI tests for Linux DevEdition on mozilla-beta r=kmoir DONTBUILD
Comment 28•7 years ago
|
||
modified patch for beta, all the tests that run on inbound don't run on beta yet thus the missing desktop-screenshot-capture tests for linux64-devedition-nightly/opt
Comment 29•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8140b96e2c0d
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•7 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: leaveopen
Updated•7 years ago
|
Keywords: leave-open
Whiteboard: leaveopen
Comment 30•7 years ago
|
||
Pushed by philringnalda@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4000d93da089 followup, mark the Linux DevEdition tests as tier-1 rather than letting them get the default tier-2
Comment 31•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/8856170020cf
Comment 32•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4000d93da089
Comment 33•7 years ago
|
||
Linux64 devedition talos tests have also been enabled (see https://bugzilla.mozilla.org/show_bug.cgi?id=1359595#c138), so I think the work here is now done.
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Comment 34•6 years ago
|
||
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
Updated•6 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•