The back button arrow is too opaque in inactive windows if the back button is disabled

VERIFIED FIXED in Firefox 55

Status

()

defect
P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: mstange, Assigned: johannh)

Tracking

({regression})

Trunk
Firefox 55
All
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55+ verified)

Details

(Whiteboard: [photon-visual][p1])

Attachments

(1 attachment)

Reporter

Description

2 years ago
[Tracking Requested - why for this release]: visual regression in the primary UI

STR:
 1. Open a new tab.
 2. See that the back button is translucent (bug 1362408) and has a gray arrow.
 3. Focus a different window to make the Firefox window inactive.

Now the button is completely opaque and has a black arrow.

This does not happen if the back button is enabled. So in inactive windows, the back button now looks more enabled when it's disabled than when it's enabled.
Reporter

Updated

2 years ago
Blocks: 1352364
Whiteboard: [photon-visual][p1]
Flags: qe-verify?
Priority: -- → P2
Assignee

Updated

2 years ago
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Iteration: --- → 55.5 - May 15
Priority: P2 → P1
Comment hidden (mozreview-request)
Assignee

Comment 2

2 years ago
This was happening because I was relying on calc() to divide the opacity of disabled elements by 2, which is apparently not working as expected (worst of all it isn't even invalid it just silently sets the opacity to 1). That's tracked in bug 956573.

I changed it to set the opacity on the toolbarbutton directly instead, creating the same effect.
See Also: → 956573
tracking as ui regression in 55.

Comment 4

2 years ago
mozreview-review
Comment on attachment 8866165 [details]
Bug 1362409 - Fix window-inactive opacity for disabled buttons on OSX.

https://reviewboard.mozilla.org/r/137768/#review141282

::: browser/themes/osx/browser.css:554
(Diff revision 1)
>  }
>  
>  /* Inactive elements are faded out on OSX */
> -
> -.toolbarbutton-1:not(:hover):-moz-window-inactive > #downloads-indicator-anchor,
> -.toolbarbutton-1:not(:hover):-moz-window-inactive > .toolbarbutton-icon,
> +.toolbarbutton-1:not(:hover):-moz-window-inactive,
> +#main-window:not([customizing]) .toolbarbutton-1:-moz-window-inactive[disabled="true"],
> +#main-window:not([customizing]) .toolbarbutton-1:-moz-window-inactive > .toolbarbutton-menubutton-button[disabled="true"] {

This line needs to be removed, I think. The parent node will already have its opacity reduced via the #main-window:not([customizing]) .toolbarbutton-1:-moz-window-inactive[disabled="true"] selector.
Attachment #8866165 - Flags: review?(dao+bmo) → review+
Comment hidden (mozreview-request)
Assignee

Comment 6

2 years ago
mozreview-review-reply
Comment on attachment 8866165 [details]
Bug 1362409 - Fix window-inactive opacity for disabled buttons on OSX.

https://reviewboard.mozilla.org/r/137768/#review141282

> This line needs to be removed, I think. The parent node will already have its opacity reduced via the #main-window:not([customizing]) .toolbarbutton-1:-moz-window-inactive[disabled="true"] selector.

Seems fine to me.

Comment 7

2 years ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e5a67e979263
Fix window-inactive opacity for disabled buttons on OSX. r=dao

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e5a67e979263
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Flags: qe-verify? → qe-verify+
QA Contact: brindusa.tot
I tested this on iMac OS X 10.10 and MacBook 10.12 with FF Nightly 55.0a1(2017-05-17) and I can confirm the fix.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.