1362409 - The back button arrow is too opaque in inactive windows if the back button is disabled

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Markus Stange [:mstange]]

[Tracking Requested - why for this release]: visual regression in the primary UI

STR:
 1. Open a new tab.
 2. See that the back button is translucent (bug 1362408) and has a gray arrow.
 3. Focus a different window to make the Firefox window inactive.

Now the button is completely opaque and has a black arrow.

This does not happen if the back button is enabled. So in inactive windows, the back button now looks more enabled when it's disabled than when it's enabled.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1362409 - Fix window-inactive opacity for disabled buttons on OSX.

Review commit: https://reviewboard.mozilla.org/r/137768/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137768/

Comment 2

[Johann Hofmann [:johannh]]

This was happening because I was relying on calc() to divide the opacity of disabled elements by 2, which is apparently not working as expected (worst of all it isn't even invalid it just silently sets the opacity to 1). That's tracked in bug 956573.

I changed it to set the opacity on the toolbarbutton directly instead, creating the same effect.

Comment 3

[Julien Cristau [:jcristau]]

tracking as ui regression in 55.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8866165 [details]
Bug 1362409 - Fix window-inactive opacity for disabled buttons on OSX.

https://reviewboard.mozilla.org/r/137768/#review141282

::: browser/themes/osx/browser.css:554
(Diff revision 1)
>  }
>  
>  /* Inactive elements are faded out on OSX */
> -
> -.toolbarbutton-1:not(:hover):-moz-window-inactive > #downloads-indicator-anchor,
> -.toolbarbutton-1:not(:hover):-moz-window-inactive > .toolbarbutton-icon,
> +.toolbarbutton-1:not(:hover):-moz-window-inactive,
> +#main-window:not([customizing]) .toolbarbutton-1:-moz-window-inactive[disabled="true"],
> +#main-window:not([customizing]) .toolbarbutton-1:-moz-window-inactive > .toolbarbutton-menubutton-button[disabled="true"] {

This line needs to be removed, I think. The parent node will already have its opacity reduced via the #main-window:not([customizing]) .toolbarbutton-1:-moz-window-inactive[disabled="true"] selector.

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 8866165 [details]
Bug 1362409 - Fix window-inactive opacity for disabled buttons on OSX.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137768/diff/1-2/

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 8866165 [details]
Bug 1362409 - Fix window-inactive opacity for disabled buttons on OSX.

https://reviewboard.mozilla.org/r/137768/#review141282

> This line needs to be removed, I think. The parent node will already have its opacity reduced via the #main-window:not([customizing]) .toolbarbutton-1:-moz-window-inactive[disabled="true"] selector.

Seems fine to me.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5a67e979263
Fix window-inactive opacity for disabled buttons on OSX. r=dao

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e5a67e979263

Comment 9

[ovidiu boca[:Ovidiu]]

I tested this on iMac OS X 10.10 and MacBook 10.12 with FF Nightly 55.0a1(2017-05-17) and I can confirm the fix.