1362571 - Saved Logins button shouldn't appear nested under the Master Password preference

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Matthew N. [:MattN]]

It doesn't make sense for the saved logins button to appear under the Master Password checkbox. It should appear under the "remember logins…" checkbox like before.

Comment 1

[Matthew N. [:MattN]]

Sorry, I guess this isn't a regression as it was wrong before the re-org…

Comment 2

[Matthew N. [:MattN]]

spec: https://mozilla.invisionapp.com/share/AP8TFZ22G#/screens/228643733

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1362571 - Move 'Saved Logins' button under the remember logins checkbox.

Review commit: https://reviewboard.mozilla.org/r/136686/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136686/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8865029 [details]
Bug 1362571 - Move 'Saved Logins' button under the remember logins checkbox.

https://reviewboard.mozilla.org/r/136686/#review140180

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e16f179a455
Move 'Saved Logins' button under the remember logins checkbox. r=jaws

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7e16f179a455

Comment 7

[Farhadur Reja Fahim]

I have reproduced this bug with Nightly 55.0a1 (2017-05-05) on Linux Mint 18, 64 bit!
The bug's fix is now verified on latest Nightly 55.0a1 (64-bit).

Nightly 55.0a1:

 Build ID 	20170604100232
 User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170607]

Comment 8

[Matthew N. [:MattN]]

Thanks