1362587 - Prevent triggering plugin infobar (workaround bug 1319105)

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, enhancement)

Description

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

We have pure JS copy to clipboard in all supported browsers. 

We know from bug 1319105 that referring to `navigator.plugins["Shockwave Flash"]` triggers the "permission to run Flash" door hanger in 55 nightly. 

Do we need this code at all to support the copy summary button in our list of supported browsers. 

If not, can we just get rid of it? 

If we can't get rid of it can we replace it with a library such as clipboard.js that doesn't fall back to Flash (and won't trigger the doorhanger.)

Comment 1

[Dylan Hardison [:dylan] (he/him)]

We're not removing harmless, working code because firefox 55 decides to have a panic attack about accessing a hash key.

Comment 2

[Kohei Yoshino [:kohei]]

To adopt progressive enhancement, we could simply hide the button when the pure JS clipboard functionality is not supported in the user's browser.

Comment 3

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

+1

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1319105_1.patch

Comment 5

[:glob ✱]

Comment on attachment 8865086 [details] [diff] [review]
1319105_1.patch

Review of attachment 8865086 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob  lgtm.

i'm also ok with dropping flash completely; iirc at the time it was added support for unpreffed execCommand('copy') was new.

Comment 6

[Mark Côté [:mcote]]

Indeed, if our recently defined tier-1 set of browsers supports pure-JS clipboard copying, I would also advocate for removing the Flash code.

Comment 7

[:glob ✱]

(In reply to Mark Côté [:mcote] from comment #6)
> Indeed, if our recently defined tier-1 set of browsers supports pure-JS
> clipboard copying, I would also advocate for removing the Flash code.

copy is supported by firefox 41, chrome 43, edge, ie 9, opera 29, and safari 10.

Comment 8

[Dylan Hardison [:dylan] (he/him)]

To [e-mail]:mozilla-bteam/bmo.git
   3a7f342..89e44ac  master -> master