1362828 - mozboot: Fix clang package download message

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chris Peterson [:cpeterson]]

When I run `mach bootstrap` to install the Stylo tool dependencies for Mac, the script hits an HTTP 403 Forbidden error when trying to download the clang tooltool package:

https://api.pub.build.mozilla.org/tooltool/sha512/cfde9a0f7f59823200f94422b4adb9a2fb5d4d07f240bbd1142c792434f6a1cbb4096d25c9853d77008fc40db0d827daa7003e78016f51241f621d6040ccc635

The Windows and Linux clang tooltool packages' URLs work correctly (using the SHA-512 hashes https://hg.mozilla.org/mozilla-central/rev/8248949d1c7434569a506d94850376df3def4a08#l10.11):

https://api.pub.build.mozilla.org/tooltool/sha512/cd3ed31acefd185f441632158dde73538c62bab7ebf2a8ec630985ab345938ec522983721ddb1bead1de22d5ac1571d50a958ae002364d739f2a78c6e7244222

https://api.pub.build.mozilla.org/tooltool/sha512/52f3fc23f0f5c98050f8b0ac7c92a6752d067582a16f712a5a58074be98975d594f9e36249fc2be7f1cc2ca6d509c663faaf2bea66f949243cc1f41651638ba6

Comment 1

[Chris Peterson [:cpeterson]]

Nathan, I think this HTTP 403 Forbidden error really is a permissions problem with the clang tooltool package for Mac. If I alter the URL's hash, the server returns HTTP 404 Not Found, which suggests that the Mac package hash is correct and the file exists on the server.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1362828 - mozboot: Fix clang package download message.

The Python print() function's does not take a format string, so the extraneous %s here inadvertently prints "Downloading clang package from %s https://..." instead of "Downloading clang package from https://...".

Review commit: https://reviewboard.mozilla.org/r/136860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136860/

Comment 3

[Chris Peterson [:cpeterson]]

This patch does not fix the HTTP 403 Forbidden problem. It just fixes a typo in mach bootstrap's clang package download message.

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8865190 [details]
Bug 1362828 - mozboot: Fix clang package download message.

https://reviewboard.mozilla.org/r/136860/#review140108

Whoops!  Didn't look very closely at the printed message, I guess...

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3655533be7c7
mozboot: Fix clang package download message. r=froydnj

Comment 6

[Gregory Szorc [:gps]]

Pretty sure the 403 is bug 1359968, which is fixed on mozilla-central.

Comment 8

[Ralph Giles (:rillian)]

Bug 1359968 updated the tooltool manifests, but `mach boostrap` doesn't read those directly. I've opened 1363110 about propagating the change to mozboot/stylo.py.

Comment 9

[Chris Peterson [:cpeterson]]

Bug 1363110 fixes the Mac clang package hash, so I'll morph this bug into just fixing the download message typo (dupe bug 1363106).

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3655533be7c7