1362831 - Crash in nsTArray_Impl<T>::Clear | mozilla::ConsoleReportCollector::Release

Status: RESOLVED DUPLICATE of bug 1381362

(Core :: Networking: HTTP, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-b794d306-6804-4d5f-a9cd-5c6060170507.
=============================================================

Seen while looking at crash stats - crashes started with 20170506030204: http://bit.ly/2piTBRc

Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0b255199db9d6a6f189b89b7906f99155bde3726&tochange=37a5b7f6f101df2eb292b1b6baaf1540c9920e20

ni on dragana since she mentioned she landed some networking stuff.

Comment 1

[Dragana Damjanovic [:dragana]]

This does not look my last change has cause it.

This is called from nsProtocolProxyService.cpp.

Daniel, do you know if something change around proxies, there were some bugs but I have not follow them carefully?

Comment 2

[Honza Bambas (:mayhemer)]

Actually, I think the bug lies in ConsoleReportCollector.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Yes, ConsoleReportCollector is on the stack, but its just a ref counted objected with an nsTArray.  Its unclear to me what it could be doing wrong here.  Also, it hasn't changed in a long time.

It looks to me like the channel being destroyed is not valid.

Comment 4

[Daniel Stenberg [:bagder]]

Dragana, I don't see how you suspect this to be a proxy bug. Can you elaborate?

Comment 5

[Dragana Damjanovic [:dragana]]

(In reply to Daniel Stenberg [:bagder] from comment #4)
> Dragana, I don't see how you suspect this to be a proxy bug. Can you
> elaborate?

2 reports I lookedin had something with ProxyService, but not all of them. This is TFO bug cause by antivirus software :(

Sorry for the noise.

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Dragana, are you going to take this regression?

Comment 7

[Dragana Damjanovic [:dragana]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #6)
> Hi Dragana, are you going to take this regression?

I am keeping eye on all regression from bug 1188435. That feature is disabled at the moment and crashes are gone.

Comment 8

[Marcia Knous [:marcia]]

TFO was turned on again in Bug 1367390, we will keep these crashes open until Dragana evaluates whether they should be closed or not.

Comment 9

[Andrew McCreight [:mccr8]]

12 crashes in the 5-31 Windows Nightly, making this the #13 crash for that build.

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

Since this is a TFO bug I'll move the status flag to 56 and set 55 to disabled.

Comment 11

[Dragana Damjanovic [:dragana]]

I am closing this one, signature changed a bit and there is bug 1381362