1362875 - Radio/Checkmark not shown in menus on Linux (maybe too old GTK3 version)

Status: NEW

(Core :: Widget: Gtk, defect, P3)

Description

[Chris Ramsden]

Attachment: toolbars selected in menu

In TB52.1.0, and several recent prior versions, in Linux the selected/deselected markers in menu drop-downs are not visible. 

As an example, in the attached file I show the Toolbars selection menu item. All of the toolbars are in fact selected and indeed you can see the Menu Bar, the Mail Toolbar and the FolderPane Toolbar. Other Linux users have informally confirmed similar observations.

What I do: I select a toolbar via the menu.

What happens: The toolbar becomes visible in the UI.

What should happen: A marker should appear in the menu-drop-down to indicate if a selection is active or not. 

What doesn't happen: There is no indication that a selection has been made.

The screenshot shows TB running in Safe Mode, to rule out the theme in use. Note that toolbars can be toggled on and off, so the click event handler on the menu is working. 

Same happens in other places, such as View|Layout, View|Folders, View|Threads, View|Sort by, etc etc. 

Same version of TB on Windows 7 and 10 does show these markers.

Comment 1

[Chris Ramsden]

OS: Linux 4.7.0-0.bpo.1-amd64 (x86_64) MX-16 Metamorphosis
TB: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 Build ID: 20170428151619

Comment 2

[Jorg K (CEST = GMT+2)]

Richard and Aceman, another "doesn't look right on Linux" bug for you to look at.

Chris, what's the distro? MX-16 Metamorphosis?

Comment 3

[Chris Ramsden]

Yep it is MX Linux

https://mxlinux.org/

with the Mate DE. 

The missing items are a mix of checkboxes and radio buttons.

Comment 4

[:aceman]

What is your Gtk3 version?
I do not see this on Linux.

Does it also happen in Firefox?

Comment 5

[Richard Marti (:Paenglab)]

Tested on Mint 18 and Ubuntu 17.04 the checkboxes and radioitems are visible on TB 52 and 55.

Comment 6

[Laszlo Ersek]

* I'm seeing the same on RHEL-7.3, with Thunderbird 52.1.0 (and now with 52.1.1).

* My gtk3 version is: gtk3-3.14.13-20.el7.x86_64

* I'm seeing the same in Firefox (53.0.2 (64-bit)).

Comment 7

[Richard Marti (:Paenglab)]

Maybe a issue with too old GTK3 versions.

As Laszlo sees this too in FX, moving to toolkit.

Comment 8

[Laszlo Ersek]

Found some relevant-looking patches / reports in other projects:

* https://bugs.kde.org/show_bug.cgi?id=338538
* http://trac.wxwidgets.org/ticket/17240

Comment 9

[Laszlo Ersek]

... pointing to:

https://git.gnome.org/browse/gtk+/commit/?id=2c65e259448a9ec261f0dcf420662300786204c2

Comment 10

[Laszlo Ersek]

* https://bugs.mageia.org/show_bug.cgi?id=13954

Comment 11

[Laszlo Ersek]

Can we please assign this BZ to someone? I use upstream Firefox and Thunderbird on RHEL7 every day, all day, and the missing check marks in the menus are distracting.

The problem should not be hard to reproduce (and maybe bisect) in a virtual machine running CentOS 7.

Thanks!

Comment 12

[Chris Ramsden]

If this is indeed a GTK problem, can anyone suggest what the end user is supposed to do about it? I see no obvious way to force GTK to upgrade. 

Or are we saying this is an issue when building/compiling Thunderbird?

Comment 13

[Richard Marti (:Paenglab)]

This depends of the distro. All I can say is, with Mint and GTK3 v3.18 and Fedora with v3.24 they are shown.

Comment 14

[Laszlo Ersek]

Is bug 1345432 related perhaps? (I asked there too.)

Comment 15

[Laszlo Ersek]

I've now upgraded my laptop to RHEL-7.4 Beta, implying "gtk3-3.22.10-3.el7.x86_64".

Checkboxen have re-appeared in both Thunderbird (52.1.1 (64-bit)) and Firefox (53.0.3 (64-bit)).

This confirms that this Toolkit bug is related to old GTK3 versions.

(I do think it is a Toolkit regression. Unless Mozilla deliberately dropped support for GTK3 3.14.)

Comment 16

[Laszlo Ersek]

The regression was introduced from Firefox-50.0.2 to Firefox-51.0.1. I'm
going to attach three (cropped) screenshots:

(1) Firefox 50.0.2 running on gtk3-3.14.13-20.el7.

    This is the last good version on GTK3 3.14.

(2) Firefox 51.0.1 running on gtk3-3.14.13-20.el7.

    This is the first bad version on GTK3 3.14.

(3) Firefox 51.0.1 running on gtk3-3.22.10-3.el7.

    This shows how upgrading GTK3 to 3.22 mitigates the regression.

    (Note that the submenu arrows, checkbox outlines, and check marks look
    different from case (1).)

Comment 17

[Laszlo Ersek]

Attachment: Firefox 50.0.2 running on gtk3-3.14.13-20.el7 (last good on GTK3 3.14)

Comment 18

[Laszlo Ersek]

Attachment: Firefox 51.0.1 running on gtk3-3.14.13-20.el7 (first bad on GTK3 3.14)

Comment 19

[Laszlo Ersek]

Attachment: Firefox 51.0.1 running on gtk3-3.22.10-3.el7 (regression hidden by GTK3 3.22)

Comment 20

[Laszlo Ersek]

Apparently Firefox 50.0.2 (sort of) corresponds to the FIREFOX_50_0_RELEASE hg tag:
https://hg.mozilla.org/releases/mozilla-release/rev/dc617d65c9f0cdbbe4351cc1e5c288b05f25f8f7

Similarly, Firefox 51.0.1 should correspond to FIREFOX_51_0_1_RELEASE:
https://hg.mozilla.org/releases/mozilla-release/rev/327e081221b064b05a302d7877c6e4be2949a617