stylo: Implement ComputeDistance for TransformList (and Filter/Shape)

ASSIGNED
Assigned to

Status

()

Core
CSS Parsing and Computation
P2
normal
ASSIGNED
3 months ago
2 months ago

People

(Reporter: birtles, Assigned: boris)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 months ago
In bug 1318591 we implemented ComputeDistance but not for TransformList. We need to implement this for TransformList (or Filter or Shape according to bug 1318591 comment 0). We need to do this because this is used in the DevTools animation inspector where inspecting transform lists is very common.
(Reporter)

Comment 1

3 months ago
(In reply to Brian Birtles (:birtles) from comment #0)
> In bug 1318591 we implemented ComputeDistance but not for TransformList. We
> need to implement this for TransformList (or Filter or Shape according to
> bug 1318591 comment 0). We need to do this because this is used in the
> DevTools animation inspector where inspecting transform lists is very common.

Sorry, that should refer to bug 1332633.
Blocks: 1332633
No longer blocks: 1318591
(In reply to Brian Birtles (:birtles) from comment #0)
> In bug 1318591 we implemented ComputeDistance but not for TransformList. We
> need to implement this for TransformList (or Filter or Shape according to
> bug 1318591 comment 0). We need to do this because this is used in the
> DevTools animation inspector where inspecting transform lists is very common.

'filter' is not animatable yet (bug 1362897).
(Assignee)

Comment 3

3 months ago
(In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
> (In reply to Brian Birtles (:birtles) from comment #0)
> > In bug 1318591 we implemented ComputeDistance but not for TransformList. We
> > need to implement this for TransformList (or Filter or Shape according to
> > bug 1318591 comment 0). We need to do this because this is used in the
> > DevTools animation inspector where inspecting transform lists is very common.
> 
> 'filter' is not animatable yet (bug 1362897).

OK. Looks like we can implement Shape and TransformList first.
(Reporter)

Comment 4

3 months ago
Bear in mind that the main requirement here is just that the keyframes panel in DevTools produces a sensible result so it's probably not worth spending a lot of time on difficult edge cases (but we should document any shortcuts we took with code comments and bugs as necessary).
(Assignee)

Updated

3 months ago
Assignee: nobody → boris.chiou
(Assignee)

Updated

2 months ago
Status: NEW → ASSIGNED
(Assignee)

Comment 5

2 months ago
(In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
> (In reply to Brian Birtles (:birtles) from comment #0)
> > In bug 1318591 we implemented ComputeDistance but not for TransformList. We
> > need to implement this for TransformList (or Filter or Shape according to
> > bug 1318591 comment 0). We need to do this because this is used in the
> > DevTools animation inspector where inspecting transform lists is very common.
> 
> 'filter' is not animatable yet (bug 1362897).

There are two properties using basic shape: shape-outside and clip-path, and both are not animatable now. So let's implement compute distance for transform first.
(Assignee)

Comment 6

2 months ago
I will follow the current implementation on Gecko:
1. TransformList: Bug 1272549 Comment 25
2. Shape: Bug 1286150, (https://github.com/w3c/csswg-drafts/issues/662)
3. Filter: Bug 1286151, (https://github.com/w3c/fxtf-drafts/issues/91)
(Assignee)

Updated

2 months ago
(Assignee)

Updated

2 months ago
(Assignee)

Updated

2 months ago
See Also: → bug 1272549
(Assignee)

Comment 7

2 months ago
(In reply to Boris Chiou [:boris] from comment #6)
> I will follow the current implementation on Gecko:
> 1. TransformList: Bug 1272549 Comment 25
> 2. Shape: Bug 1286150, (https://github.com/w3c/csswg-drafts/issues/662)
> 3. Filter: Bug 1286151, (https://github.com/w3c/fxtf-drafts/issues/91)

Sorry, transform list should use this: bug 1318591 comment 0
(Assignee)

Updated

2 months ago
See Also: bug 1272549bug 1318591
(Assignee)

Comment 8

2 months ago
(In reply to Boris Chiou [:boris] from comment #7)
> (In reply to Boris Chiou [:boris] from comment #6)
> > I will follow the current implementation on Gecko:
> > 1. TransformList: Bug 1272549 Comment 25
> > 2. Shape: Bug 1286150, (https://github.com/w3c/csswg-drafts/issues/662)
> > 3. Filter: Bug 1286151, (https://github.com/w3c/fxtf-drafts/issues/91)
> 
> Sorry, transform list should use this: bug 1318591 comment 0

And bug 1318591 comment 0 might be much harder on stylo because we need to get layout info from Gecko side, and I guess that might be also a problem for mismatched transform list. Maybe we should wait for https://github.com/servo/servo/issues/13267 first.
You need to log in before you can comment on or make changes to this bug.