stylo: The interpolation of perspective transform is not correct

RESOLVED FIXED in Firefox 57

Status

()

Core
CSS Parsing and Computation
P2
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: boris, Assigned: boris)

Tracking

(Blocks: 1 bug)

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

5 months ago
In add_weighted_transform_lists [1], we convert a perspective function into a ComputedMatrix, but we apply the perspective length to a wrong matrix item. We should put it into m34, instead of m43. m43 is for translate parameter Z [2].

[1] http://searchfox.org/mozilla-central/rev/c329d562fb6c6218bdb79290faaf015467ef89e2/servo/components/style/properties/helpers/animated_properties.mako.rs#1732-1733
[2] https://www.w3.org/TR/css-transforms-1/#PerspectiveDefined
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

5 months ago
Blocks: 1288269
No longer blocks: 1362896

Updated

5 months ago
Priority: -- → P2

Comment 3

5 months ago
mozreview-review
Comment on attachment 8895756 [details]
Bug 1389023 - Fix the conversion from Perspective into ComputedMatrix.

https://reviewboard.mozilla.org/r/167086/#review173198
Attachment #8895756 - Flags: review?(bbirtles) → review+
(Assignee)

Comment 4

5 months ago
Created attachment 8896845 [details] [review]
Servo PR, #18068

Comment 5

5 months ago
https://hg.mozilla.org/mozilla-central/rev/9c9e455241e5
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.