Closed
Bug 1389023
Opened 7 years ago
Closed 7 years ago
stylo: The interpolation of perspective transform is not correct
Categories
(Core :: CSS Parsing and Computation, enhancement, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: boris, Assigned: boris)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
In add_weighted_transform_lists [1], we convert a perspective function into a ComputedMatrix, but we apply the perspective length to a wrong matrix item. We should put it into m34, instead of m43. m43 is for translate parameter Z [2]. [1] http://searchfox.org/mozilla-central/rev/c329d562fb6c6218bdb79290faaf015467ef89e2/servo/components/style/properties/helpers/animated_properties.mako.rs#1732-1733 [2] https://www.w3.org/TR/css-transforms-1/#PerspectiveDefined
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Updated•7 years ago
|
Priority: -- → P2
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8895756 [details] Bug 1389023 - Fix the conversion from Perspective into ComputedMatrix. https://reviewboard.mozilla.org/r/167086/#review173198
Attachment #8895756 -
Flags: review?(bbirtles) → review+
Assignee | ||
Comment 4•7 years ago
|
||
![]() |
||
Comment 5•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9c9e455241e5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•