Closed Bug 1362937 Opened 3 years ago Closed 3 years ago

[Form Autofill] autofill's autocomplete popup filtering is broken

Categories

(Toolkit :: Form Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: steveck, Assigned: steveck)

References

Details

(Whiteboard: [form autofill:M3])

Attachments

(1 file)

It happens when you start to type in a field instead of just hitting the down arrow with no text. Here's the error message: TypeError: name is undefined ProfileStorage.jsm:287:7.
Comment on attachment 8865349 [details]
Bug 1362937 - [Form Autofill] autofill's autocomplete popup filtering is broken.

https://reviewboard.mozilla.org/r/136992/#review139970

Thanks!
Attachment #8865349 - Flags: review?(MattN+bmo) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 2627efeab7f7 -d c01835554dc1: rebasing 394353:2627efeab7f7 "Bug 1362937 - [Form Autofill] autofill's autocomplete popup filtering is broken. r=MattN" (tip)
merging browser/extensions/formautofill/ProfileStorage.jsm
merging browser/extensions/formautofill/test/unit/test_profileStorage.js
warning: conflicts while merging browser/extensions/formautofill/ProfileStorage.jsm! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
I'll land this
Blocks: 1361560
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0669259020b
[Form Autofill] Handle undefined profile fields in autocomplete filtering. r=MattN
this caused merge conflict with m-c like warning: conflicts while merging browser/extensions/formautofill/test/unit/test_profileStorage.js! (edit, then use 'hg resolve --mark')
Flags: needinfo?(schung)
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b55ab643feb
Backed out changeset d0669259020b for causing merge conflicts when merging to m-c
Patch rebased.
Flags: needinfo?(schung)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/773f2202cf94
[Form Autofill] autofill's autocomplete popup filtering is broken. r=MattN
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/773f2202cf94
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.