Closed
Bug 1361560
Opened 7 years ago
Closed 7 years ago
Enable Form Autofill by default on Nightly
Categories
(Toolkit :: Form Manager, enhancement)
Toolkit
Form Manager
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: MattN, Assigned: MattN)
References
Details
(Whiteboard: [form autofill:M2])
Attachments
(1 file, 1 obsolete file)
In order to get more testing of the feature, let's enable the feature for Nightly-only.
Assignee | ||
Comment 1•7 years ago
|
||
We either need bug 1340477 landed or we need to also enable dom.forms.autocomplete.experimental temporarily on Nightly-only.
Assignee | ||
Comment 2•7 years ago
|
||
After learning about bug 1274018, it looks like we don't need bug 1360374 before landing: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=54ab8a55ca635696180e004b80eb446c48b8dab2&newProject=try&newRevision=2c06a84dad5e4a61a04c36ac01b84bca49564a52&framework=1&showOnlyImportant=0&showOnlyConfident=1
No longer depends on: 1360374
Assignee | ||
Comment 3•7 years ago
|
||
Try with unit tests and talos: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=4bddbc07c726e827f21eb97ecf4bd854063a4aa5&newProject=try&newRevision=6f0803130f5ad8f0b567b933cde0609c0e317c0a&framework=1&showOnlyImportant=0&showOnlyConfident=1
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Assignee | ||
Updated•7 years ago
|
Version: 53 Branch → Trunk
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8865060 [details] Bug 1361560 - Enable Form Autofill by default on Nightly. https://reviewboard.mozilla.org/r/136734/#review139834 Looks good. BTW, I'm going to rename the naming of `profiles` in the JSON file. After the renaming patch in bug 1359978 lands, the profile that users already save in storage will become unavailable. Should we wait for bug 1359978 or do you think we don't need to rename that entry in the JSON file?
Attachment #8865060 -
Flags: review?(lchang) → review+
Comment hidden (mozreview-request) |
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/dfe330725cf7 Enable Form Autofill by default on Nightly. r=lchang
Comment 8•7 years ago
|
||
backed out for wpt failures like https://treeherder.mozilla.org/logviewer.html#?job_id=97520621&repo=autoland&lineNumber=2522 & https://treeherder.mozilla.org/logviewer.html#?job_id=97520951&repo=autoland&lineNumber=2077
Backout by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b0c35be45a41 Backed out changeset dfe330725cf7 for wpt failures in HTMLSelectElement interface: attribute autocomplete
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 13•7 years ago
|
||
mozreview-review |
Comment on attachment 8865760 [details] Bug 1361560 - Force experimental autocomplete pref on during wpt DOM interface test. https://reviewboard.mozilla.org/r/137374/#review140448 ::: testing/web-platform/meta/html/dom/interfaces.html.ini:3 (Diff revision 1) > [interfaces.html] > type: testharness > - prefs: [dom.forms.inputmode:true, dom.dialog_element.enabled:true] > + prefs: [dom.forms.inputmode:true, dom.dialog_element.enabled:true, dom.forms.autocomplete.experimental:true] So "dom.forms.autocomplete.experimental" is to enable @autocomplete values other than "on/off", and also to enable @autocomplete attribute in `HTMLSelectElement`, right? Maybe we should add comments on that somewhere.
Attachment #8865760 -
Flags: review?(jjong) → review+
Assignee | ||
Comment 14•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8865760 [details] Bug 1361560 - Force experimental autocomplete pref on during wpt DOM interface test. https://reviewboard.mozilla.org/r/137374/#review140448 > So "dom.forms.autocomplete.experimental" is to enable @autocomplete values other than "on/off", and also to enable @autocomplete attribute in `HTMLSelectElement`, right? Maybe we should add comments on that somewhere. Yes. Hmm… I can't figure out a way to add a comment to these .html.ini files… the usual semicolon methods gives an error and I can't find other examples of comments in those files. I'm going to land this without a comment. jgraham also gave r+ over IRC.
Comment 15•7 years ago
|
||
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/mozilla-inbound/rev/1c57b5d15190 Enable Form Autofill by default on Nightly. r=lchang https://hg.mozilla.org/integration/mozilla-inbound/rev/c7bfebd287aa Force experimental autocomplete pref on during wpt DOM interface test. r=jgraham,jessica
![]() |
||
Comment 16•7 years ago
|
||
Backed out for failing (= unexpected passes) web-platform-test form-autocomplete.html: https://hg.mozilla.org/integration/mozilla-inbound/rev/056dff7e2ec58d9b979da1c03ce8aeba75eee1bd https://hg.mozilla.org/integration/mozilla-inbound/rev/8d3de2fb7b3e43627650ffe9049aa51037dec6ed Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c7bfebd287aa839bc1f655d321d7b455fc2be0a7&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Log with unexpected passes: https://treeherder.mozilla.org/logviewer.html#?job_id=97744060&repo=mozilla-inbound
Flags: needinfo?(MattN+bmo)
Assignee | ||
Comment 17•7 years ago
|
||
I think we can wait until bug 1340477 lands instead of fixing the wpt tests here.
Depends on: 1340477
Flags: needinfo?(MattN+bmo)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8865760 -
Attachment is obsolete: true
Comment 19•7 years ago
|
||
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/mozilla-inbound/rev/a9e4724a00d2 Enable Form Autofill by default on Nightly. r=lchang
![]() |
||
Comment 20•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a9e4724a00d2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee | ||
Comment 21•7 years ago
|
||
https://blog.nightly.mozilla.org/2017/05/23/preview-form-autofill-in-firefox-nightly/
You need to log in
before you can comment on or make changes to this bug.
Description
•