Closed Bug 1361560 Opened 4 years ago Closed 4 years ago

Enable Form Autofill by default on Nightly

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla55

Tracking Flags:

Tracking

Status

firefox55

---

fixed

People

(Reporter: MattN, Assigned: MattN)

References

Details

(Whiteboard: [form autofill:M2])

Attachments

(1 file, 1 obsolete file)

Bug 1361560 - Enable Form Autofill by default on Nightly. 4 years ago Matthew N. [:MattN] 59 bytes, text/x-review-board-request	lchang : review+	Details
Bug 1361560 - Force experimental autocomplete pref on during wpt DOM interface test. 4 years ago Matthew N. [:MattN] 59 bytes, text/x-review-board-request	jessica : review+	Details

Matthew N. [:MattN]

Assignee

Description

•

4 years ago

In order to get more testing of the feature, let's enable the feature for Nightly-only.

Matthew N. [:MattN]

Assignee

Comment 1

•

4 years ago

We either need bug 1340477 landed or we need to also enable dom.forms.autocomplete.experimental temporarily on Nightly-only.

Matthew N. [:MattN]

Assignee

Comment 2

•

4 years ago

After learning about bug 1274018, it looks like we don't need bug 1360374 before landing:

https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=54ab8a55ca635696180e004b80eb446c48b8dab2&newProject=try&newRevision=2c06a84dad5e4a61a04c36ac01b84bca49564a52&framework=1&showOnlyImportant=0&showOnlyConfident=1

No longer depends on: 1360374

Matthew N. [:MattN]

Assignee

Updated

•

4 years ago

Depends on: 1362584

Matthew N. [:MattN]

Assignee

Comment 3

•

4 years ago

Try with unit tests and talos: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=4bddbc07c726e827f21eb97ecf4bd854063a4aa5&newProject=try&newRevision=6f0803130f5ad8f0b567b933cde0609c0e317c0a&framework=1&showOnlyImportant=0&showOnlyConfident=1

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/136734/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136734/

Matthew N. [:MattN]

Assignee

Updated

•

4 years ago

Assignee: nobody → MattN+bmo

Status: NEW → ASSIGNED

Matthew N. [:MattN]

Assignee

Updated

•

4 years ago

Version: 53 Branch → Trunk

Luke Chang [:lchang] (inactive)

Comment 5

•

4 years ago

mozreview-review

Comment on attachment 8865060 [details]
Bug 1361560 - Enable Form Autofill by default on Nightly.

https://reviewboard.mozilla.org/r/136734/#review139834

Looks good.

BTW, I'm going to rename the naming of `profiles` in the JSON file. After the renaming patch in bug 1359978 lands, the profile that users already save in storage will become unavailable. Should we wait for bug 1359978 or do you think we don't need to rename that entry in the JSON file?

Attachment #8865060 - Flags: review?(lchang) → review+

Luke Chang [:lchang] (inactive)

Updated

•

4 years ago

Depends on: 1362911

Matthew N. [:MattN]

Assignee

Updated

•

4 years ago

Depends on: 1362937

Comment hidden (mozreview-request)

Comment on attachment 8865060 [details]
Bug 1361560 - Enable Form Autofill by default on Nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136734/diff/1-2/

Pulsebot

Comment 7

•

4 years ago

Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/dfe330725cf7
Enable Form Autofill by default on Nightly. r=lchang

Iris Hsiao [:ihsiao]

Comment 8

•

4 years ago

backed out for wpt failures like https://treeherder.mozilla.org/logviewer.html#?job_id=97520621&repo=autoland&lineNumber=2522 & https://treeherder.mozilla.org/logviewer.html#?job_id=97520951&repo=autoland&lineNumber=2077

Pulsebot

Comment 9

•

4 years ago

Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b0c35be45a41
Backed out changeset dfe330725cf7 for wpt failures in HTMLSelectElement interface: attribute autocomplete

Comment hidden (mozreview-request)

Since the pref is enabled for Nightly-only for now, have the WPT test force it on so that
it doesn't fail at merge day.

Review commit: https://reviewboard.mozilla.org/r/137374/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137374/

Comment hidden (mozreview-request)

Comment on attachment 8865060 [details]
Bug 1361560 - Enable Form Autofill by default on Nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136734/diff/2-3/

Matthew N. [:MattN]

Assignee

Comment 12

•

4 years ago

Please autoland this if it gets r+

Jessica Jong [:jessica] (inactive)

Comment 13

•

4 years ago

mozreview-review

Comment on attachment 8865760 [details]
Bug 1361560 - Force experimental autocomplete pref on during wpt DOM interface test.

https://reviewboard.mozilla.org/r/137374/#review140448

::: testing/web-platform/meta/html/dom/interfaces.html.ini:3
(Diff revision 1)
>  [interfaces.html]
>    type: testharness
> -  prefs: [dom.forms.inputmode:true, dom.dialog_element.enabled:true]
> +  prefs: [dom.forms.inputmode:true, dom.dialog_element.enabled:true, dom.forms.autocomplete.experimental:true]

So "dom.forms.autocomplete.experimental" is to enable @autocomplete values other than "on/off", and also to enable @autocomplete attribute in `HTMLSelectElement`, right? Maybe we should add comments on that somewhere.

Attachment #8865760 - Flags: review?(jjong) → review+

Matthew N. [:MattN]

Assignee

Comment 14

•

4 years ago

mozreview-review-reply

Comment on attachment 8865760 [details]
Bug 1361560 - Force experimental autocomplete pref on during wpt DOM interface test.

https://reviewboard.mozilla.org/r/137374/#review140448

> So "dom.forms.autocomplete.experimental" is to enable @autocomplete values other than "on/off", and also to enable @autocomplete attribute in `HTMLSelectElement`, right? Maybe we should add comments on that somewhere.

Yes. Hmm… I can't figure out a way to add a comment to these .html.ini files… the usual semicolon methods gives an error and I can't find other examples of comments in those files. I'm going to land this without a comment. jgraham also gave r+ over IRC.

Pulsebot

Comment 15

•

4 years ago

Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c57b5d15190
Enable Form Autofill by default on Nightly. r=lchang
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7bfebd287aa
Force experimental autocomplete pref on during wpt DOM interface test. r=jgraham,jessica

Sebastian Hengst [:aryx] (needinfo on intermittent or backout)

Comment 16

•

4 years ago

Backed out for failing (= unexpected passes) web-platform-test form-autocomplete.html:

https://hg.mozilla.org/integration/mozilla-inbound/rev/056dff7e2ec58d9b979da1c03ce8aeba75eee1bd
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d3de2fb7b3e43627650ffe9049aa51037dec6ed

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c7bfebd287aa839bc1f655d321d7b455fc2be0a7&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Log with unexpected passes: https://treeherder.mozilla.org/logviewer.html#?job_id=97744060&repo=mozilla-inbound

Flags: needinfo?(MattN+bmo)

John Dai[:jdai]

Updated

•

4 years ago

Comment 17

•

4 years ago

I think we can wait until bug 1340477 lands instead of fixing the wpt tests here.

Depends on: 1340477

Flags: needinfo?(MattN+bmo)

John Dai[:jdai]

Updated

•

4 years ago

Updated

•

4 years ago

Attachment #8865760 - Attachment is obsolete: true

Pulsebot

Comment 19

•

4 years ago

Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9e4724a00d2
Enable Form Autofill by default on Nightly. r=lchang

Sebastian Hengst [:aryx] (needinfo on intermittent or backout)

Comment 20

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/a9e4724a00d2

Status: ASSIGNED → RESOLVED

Closed: 4 years ago

status-firefox55: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla55

Joel Maher ( :jmaher ) (UTC -0800)

Updated

•

4 years ago

Depends on: 1364477

Matthew N. [:MattN]

Assignee

Comment 21

•

4 years ago

https://blog.nightly.mozilla.org/2017/05/23/preview-form-autofill-in-firefox-nightly/

You need to log in before you can comment on or make changes to this bug.