Closed Bug 1362941 Opened 4 years ago Closed 4 years ago

Label Runnables in dom/file/FileReader.cpp

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bevis, Assigned: bevis)

References

Details

(Whiteboard: [QDL][TDC-MVP][DOM])

Attachments

(1 file)

FileReader holds FileReader::mTarget as owning event target for runnable dispatching, timercallback and AsyncWait from InputStream.

File this bug to set FileReader::mTarget to aGlobal->EventTargetFor(TaskCategory::Other) at Constructor instead of do_GetCurrentThread() when creating from a window global.
The runnables for TimerCallback and AsyncWait from InputStream are done on FileReader::mEventTarget.

To support DocGroup labeling, we set FileReader::mEventTarget to the one provided by nsIGlobalObject instead of the current thread.

:baku,

May I have your review for this change?

Thanks!
Attachment #8865355 - Flags: review?(amarchesini)
Attachment #8865355 - Flags: review?(amarchesini) → review+
Pushed by btseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d08d55ccca0
Set DocGroup-EventTarget from nsIGlobalObject to have dispatched runnables labeled. r=baku
https://hg.mozilla.org/mozilla-central/rev/1d08d55ccca0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Whiteboard: [QDL][TDC-MVP][DOM]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.