1362941 - Label Runnables in dom/file/FileReader.cpp

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

FileReader holds FileReader::mTarget as owning event target for runnable dispatching, timercallback and AsyncWait from InputStream.

File this bug to set FileReader::mTarget to aGlobal->EventTargetFor(TaskCategory::Other) at Constructor instead of do_GetCurrentThread() when creating from a window global.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Set DocGroup-EventTarget from nsIGlobalObject to have dispatched runnables labeled.

The runnables for TimerCallback and AsyncWait from InputStream are done on FileReader::mEventTarget.

To support DocGroup labeling, we set FileReader::mEventTarget to the one provided by nsIGlobalObject instead of the current thread.

:baku,

May I have your review for this change?

Thanks!

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

treeherder result looks fine:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=079c3ed6c4f9b295182bb07c6efc530e3afb4159

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d08d55ccca0
Set DocGroup-EventTarget from nsIGlobalObject to have dispatched runnables labeled. r=baku

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1d08d55ccca0