Closed Bug 1359686 Opened 3 years ago Closed 2 years ago

[meta] Label runnables in dom/file

Categories

(Core :: DOM: Core & HTML, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: bevis, Assigned: bevis)

References

(Blocks 1 open bug)

Details

(Keywords: meta)

Runnable dispatching, nsTimer, nsIAsync(In|Out)putStream::AsyncWait(), ReleaseOnMainThread, and IPDLs are used in dom/file:
http://searchfox.org/mozilla-central/search?q=Dispatch%7CAsyncWait%7CTimer%7CAbstractThread%7CProxyRelease%7CReleaseOnMainThread&case=false&regexp=true&path=dom%2Ffile%2F
which create runnables to be labeled if they are dispatched to the main thread of content process to support the performance improvement in Quantum-DOM:
https://wiki.mozilla.org/Quantum/DOM

This bug is to track the labeling task in dom/file.

Note: The nsIAsyncInputStream::AsyncWait() and ReleaseOnMainThread are the ones in high frequency according to bug 1333984 comment 11.
(They are nsInputStreamReadyEvent and ProxyReleaseEvent accordingly.)

Here shows what runnables shall be labeled:
https://wiki.mozilla.org/Quantum/DOM#Q3:_What_runnables_shall_be_labeled.3F
For the replacement of NS_Dispatch(Main|Current)Thread or nsIEventTarget:
https://wiki.mozilla.org/Quantum/DOM#Dispatching
https://wiki.mozilla.org/Quantum/DOM#Event_Targets
Labeling IPC Actors:
https://wiki.mozilla.org/Quantum/DOM#IPC_Actors
Labeling for AbstractThread::MainThread()
https://wiki.mozilla.org/Quantum/DOM#AbstractThread::MainThread
Labeling TimerCallback:
https://wiki.mozilla.org/Quantum/DOM#Q4:_How_do_I_specify_a_label_for_an_nsITimer_TimerCallback.3F
According to the high frequency, this sounds P1 to me. 
Bevis, are you going to work on this?
Priority: -- → P1
Yes, I'm taking this one to follow up.
Assignee: nobody → btseng
Depends on: 1362941
Depends on: 1362944
Depends on: 1362945
Depends on: 1362946
Keywords: meta
Summary: Label runnables in dom/file → [meta] Label runnables in dom/file
Can we add the TDC-MVP Whitelabel?
Flags: needinfo?(htsai)
(In reply to Mahendra Potharaju [:mahe] from comment #3)
> Can we add the TDC-MVP Whitelabel?

Yes, we can.
We are breaking down this meta into several pieces. We will review them and make sure the whiteboard labelled accordingly. Will get back to you later, so keeping the NI flag.
Flags: needinfo?(htsai)
Whiteboard: [QDL][TDC-MVP][DOM]
Removing [QDL] whiteboard from this meta bug.
Whiteboard: [QDL][TDC-MVP][DOM]
All dependencies are clear. \o/
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.