1362951 - CC list implies there's a drop-down menu, but clicking the dropdown button treats it as send email

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Mark Banner (:standard8)]

On the general bug view, if I expand the CC list to show it, the people's details are formatted in exactly the same way as for other fields, e.g. reporter, assignee etc.

It has the underline and the drop-down arrow at the end.

However, if I click one of the CC list items, it always tries to send email rather than showing me the drop-down menu so that I can see their profile/activity etc.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Basically a result of how we hook up the event to the show_usermenu links.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Notes from IRC:

17:07 <dylan> so the user menu happens because of this code: https://github.com/mozilla-bteam/bmo/blob/master/extensions/BMO/web/js/edituser_menu.js#L48
17:08 <dylan> but the CC list is generated after the page is loaded
17:09 <CGI683>  I'll take a look at it looks easy
17:10 <dylan> and here is where the cc list is updated:
17:10 <dylan> https://github.com/mozilla-bteam/bmo/blob/master/extensions/BugModal/web/bug_modal.js#L222
17:10 <dylan> so I think you'll want to hook up a click() event to that, which just calls show_usermenu($this.data('user-id'), $this.data('user-email'), $this.data('show-edit'));

Comment 3

[bitout.cecelia]

Attachment: bug_modal.js

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1362951_1.patch

Thank you and congratulations on your first patch to BMO

It is hard to review a single file, so I used the file you attached to generate a diff:

cp bug_modal.js ./extensions/BugModal/web/bug_modal.js
git diff > 1362951_1.patch

I will now review this diff.

It seems you might have had some trouble getting generating a pull request --
I'd be happy to take some time to go over that; we can chat about it in #bmo on irc.mozilla.org if you like.

Comment 6

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request

Looks like bitout.cecelia is inactive for the past 2 years so I gave it a shot.

Comment 7

[Kohei Yoshino [:kohei]]

Merged to master.