Closed Bug 1362980 Opened 7 years ago Closed 7 years ago

SendTo Extension crashes when calling sendSyncPing

Categories

(Firefox for iOS :: General, defect, P1)

Product:
Firefox for iOS
Component:
General
Platform:
Other
iOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Iteration:
1.25
Tracking Flags:
Tracking Status
fxios-v7.0 --- unaffected
fxios 8.0+ ---
fxios-v8.0 --- affected

People

(Reporter: csuciu, Assigned: st3fan)

Details

(Keywords: crash, regression, reproducible, Whiteboard: [MobileCore])

Attachments

(3 files, 1 obsolete file)

SendTo 08-05-2017, 14-23.crash
46.57 KB, text/plain
Details
SendTo 08-06-2017, 15-19.crash
45.01 KB, text/plain
Details
PR https://github.com/mozilla-mobile/firefox-ios/pull/2892
55 bytes, text/x-github-pull-request
jhugman
: review+
Details | Review 
master d43c368
iPhone 6 Plus (10.3.1)

1. Log into FxA
2. Open a webpage
3. Open Share menu
4. Select 'Send Tab'

Result: Firefox crashes
tracking-fxios: ? → 8.0+
Priority: -- → P1
Whiteboard: [MobileCore]
The crash also happens when trying to 'Send Tab' from Safari
Firefox Beta 8.0(5) is also affected.
Thread 3

Thread 3 Crashed:
0   libdispatch.dylib             	0x000000018971f800 dispatch_sync_f + 0
1   GCDWebServers                 	0x00000001027d2c38 GCDWebServerFormatRFC822 (GCDWebServerFunctions.m:120)
2   Telemetry                     	0x00000001016edac8 0x1016e4000 + 39624


Telemetry crash?
Flags: needinfo?(sarentz)
Iteration: --- → 1.23
I can't reproduce this bug on Fennec / master.
Flags: needinfo?(sarentz) → needinfo?(catalin.suciu)
SendTo still crashes on master although not every time. Please see the new crash report, which is different than the one initially attached.

Also, Send Tab extension sometimes fails to display the list of connected devices (without crashing).

https://www.youtube.com/watch?v=n4bOU08H7ZI

Tested on master 4538e6d3e42 running on iPhone 6 Plus (10.3.2)
Flags: needinfo?(catalin.suciu)
I can reproduce the above on Beta 8.0v3672 also.
Iteration: 1.23 → 1.24
P1 reproducible crash on 8.0 without an owner
Could you please test this again on the latest master. We had some changes to app groups
I'm able to reproduce in latest master.

Send Tab is either crashing or doesn't display the list of connected devices.
Iteration: 1.24 → 1.25
Assignee: nobody → sarentz
Summary: [Regression] Crash in SendTo PlugInKit: [PKService run] + 752 → SendTo Extension crashes when calling sendSyncPing
We should not be calling `sendSyncPing` when running outside of the application. This patch checks if `profile.app` is set to find out if we are in the app or an extension. This is not ideal but there is no other good way to discover this at runtime it seems.
Attachment #8883620 - Flags: review?(jhugman)
Status: NEW → ASSIGNED
Whiteboard: [MobileCore] → [MobileCore][needsuplift]
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [MobileCore][needsuplift] → [MobileCore]
I don't think this patch fixes the problem.

profile.app is no longer used. The property should've been deleted as part of Bug 1373202. We should also be using a method to hide the implementation details of isApplicationProfile().
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8883620 - Flags: review?(jhugman) → feedback+
This patch introduces an `AppInfo.isApplication` computed property that will tell us if we are running as part of an UIApplication. This is used to decide if we need to collect sync ping info.
Attachment #8883620 - Attachment is obsolete: true
Attachment #8883794 - Flags: review?(jhugman)
Attachment #8883794 - Flags: review?(jhugman) → review+
New PR landed and uplifted to v8.x
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
I can't reproduce the crash in Beta 8.0 (4467)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: