46.57 KB, text/plain
45.01 KB, text/plain
55 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
Created attachment 8865393 [details] SendTo 08-05-2017, 14-23.crash master d43c368 iPhone 6 Plus (10.3.1) 1. Log into FxA 2. Open a webpage 3. Open Share menu 4. Select 'Send Tab' Result: Firefox crashes
The crash also happens when trying to 'Send Tab' from Safari
Firefox Beta 8.0(5) is also affected.
Thread 3 Thread 3 Crashed: 0 libdispatch.dylib 0x000000018971f800 dispatch_sync_f + 0 1 GCDWebServers 0x00000001027d2c38 GCDWebServerFormatRFC822 (GCDWebServerFunctions.m:120) 2 Telemetry 0x00000001016edac8 0x1016e4000 + 39624 Telemetry crash?
I can't reproduce this bug on Fennec / master.
Created attachment 8875703 [details] SendTo 08-06-2017, 15-19.crash SendTo still crashes on master although not every time. Please see the new crash report, which is different than the one initially attached. Also, Send Tab extension sometimes fails to display the list of connected devices (without crashing). https://www.youtube.com/watch?v=n4bOU08H7ZI Tested on master 4538e6d3e42 running on iPhone 6 Plus (10.3.2)
I can reproduce the above on Beta 8.0v3672 also.
P1 reproducible crash on 8.0 without an owner
Could you please test this again on the latest master. We had some changes to app groups
I'm able to reproduce in latest master. Send Tab is either crashing or doesn't display the list of connected devices.
Created attachment 8883620 [details] [review] PR https://github.com/mozilla-mobile/firefox-ios/pull/2885 We should not be calling `sendSyncPing` when running outside of the application. This patch checks if `profile.app` is set to find out if we are in the app or an extension. This is not ideal but there is no other good way to discover this at runtime it seems.
I don't think this patch fixes the problem. profile.app is no longer used. The property should've been deleted as part of Bug 1373202. We should also be using a method to hide the implementation details of isApplicationProfile().
Created attachment 8883794 [details] [review] PR https://github.com/mozilla-mobile/firefox-ios/pull/2892 This patch introduces an `AppInfo.isApplication` computed property that will tell us if we are running as part of an UIApplication. This is used to decide if we need to collect sync ping info.
New PR landed and uplifted to v8.x
I can't reproduce the crash in Beta 8.0 (4467)