Closed Bug 1363127 Opened 4 years ago Closed 4 years ago

"ipc/mscom/ProxyStream.cpp(78): error C2065: 'nsPrintfCString': undeclared identifier" with --disable-accessibility

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1344187 +++

This turned up on a Try push I did recently with --disable-accessibility. I missed it before because --disable-crashreporter masked the issue. Per aklotz, should just need an nsPrintfCString.h include at the top.
Comment on attachment 8865579 [details] [diff] [review]
include nsPrintfCString.h in ProxyStream.cpp

Review of attachment 8865579 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed.

::: ipc/mscom/ProxyStream.cpp
@@ +13,5 @@
>  #ifdef MOZ_CRASHREPORTER
>  #include "nsExceptionHandler.h"
>  #endif
>  
> +#include "nsPrintfCString.h"

Please move this immediately below the nsExceptionHandler.h include inside the MOZ_CRASHREPORTER block.
Attachment #8865579 - Flags: review?(aklotz) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e53435c89be3
Include nsPrintfCString.h in ProxyStream.cpp to fix --disable-accessibility bustage. r=aklotz
https://hg.mozilla.org/mozilla-central/rev/e53435c89be3
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.