Add a "bookmark" item to the page action menu

VERIFIED FIXED in Firefox 55

Status

()

enhancement
P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: Gijs, Assigned: adw)

Tracking

(Blocks 2 bugs)

unspecified
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 verified)

Details

(Whiteboard: [photon-structure])

Attachments

(1 attachment)

The page action menu should have 'bookmark' and 'save to pocket' items at the top.
Flags: qe-verify+
Whiteboard: [photon-structure]
Priority: -- → P2
QA Contact: gwimberly
Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 55.6 - May 29
Priority: P2 → P1
Bryan, I presume that "Bookmark This Page" should behave like the current menu item of the same name in the main menu bar?  i.e.:

(1) If the current page isn't bookmarked, the label reads, "Bookmark This Page".  If the page is bookmarked, the label reads, "Edit This Bookmark".

(2) In either case, when you click the item, the bookmark panel opens.

(3) When the page is bookmarked, do you want to use the filled star image, or should we always use the outlined star image?
Flags: needinfo?(bbell)
(In reply to Drew Willcoxon :adw from comment #1)
> Bryan, I presume that "Bookmark This Page" should behave like the current
> menu item of the same name in the main menu bar?  i.e.:

That's right, the behavior should be the same for items in the Action Menu and in the toolbar.

> (1) If the current page isn't bookmarked, the label reads, "Bookmark This
> Page".  If the page is bookmarked, the label reads, "Edit This Bookmark".

Yep.

> (2) In either case, when you click the item, the bookmark panel opens.
>
> (3) When the page is bookmarked, do you want to use the filled star image,
> or should we always use the outlined star image?

If it's bookmarked, we should show the filled-in star.
Flags: needinfo?(bbell)
I'd like to break this bug into a bookmark bug and a Pocket bug, in the interest of not blocking the bookmark part on the Pocket part.  The Pocket part is a little harder since it's an extension.

I'll make this bug the bookmark bug.
Summary: Add "save to pocket" and "bookmark" items to the page action menu → Add a "bookmark" items to the page action menu
I filed bug 1367927 for Pocket.
Comment on attachment 8871518 [details]
Bug 1363183 - Add a "bookmark" item to the page action menu.

https://reviewboard.mozilla.org/r/142986/#review147020

Well, this is just awesomeness in go! Fun to have this one in before the weekend ;-)
Nice work!
Attachment #8871518 - Flags: review?(mdeboer) → review+
Thanks Mike.  Try looks good, landing.
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ddfc6dc2fe67
Add a "bookmark" item to the page action menu. r=mikedeboer
Summary: Add a "bookmark" items to the page action menu → Add a "bookmark" item to the page action menu
https://hg.mozilla.org/mozilla-central/rev/ddfc6dc2fe67
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I can see this feature implemented on latest nightly 55.0a1  in Windows 8.1, 64 bit 

Build ID 	20170531030204
User Agent      Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170531]
Verified on Windows, Mac, and Ubuntu on newest Nightly.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
With Bug 1352120, we have a bookmark-star button in the location bar. I think we should remove bookmark item in the page action menu because those are the duplicate feature.
It's going to be in both the menu and urlbar by default.  You'll be able to open a context menu inside the menu and add/remove each item to the urlbar as you'd like.
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.