Closed
Bug 1363183
Opened 8 years ago
Closed 8 years ago
Add a "bookmark" item to the page action menu
Categories
(Firefox :: Address Bar, enhancement, P1)
Firefox
Address Bar
Tracking
()
Tracking | Status | |
---|---|---|
firefox55 | --- | verified |
People
(Reporter: Gijs, Assigned: adw)
References
(Blocks 1 open bug)
Details
(Whiteboard: [photon-structure])
Attachments
(1 file)
The page action menu should have 'bookmark' and 'save to pocket' items at the top.
Reporter | ||
Updated•8 years ago
|
Flags: qe-verify+
Whiteboard: [photon-structure]
Updated•8 years ago
|
Priority: -- → P2
QA Contact: gwimberly
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → adw
Status: NEW → ASSIGNED
Updated•8 years ago
|
Iteration: --- → 55.6 - May 29
Priority: P2 → P1
Assignee | ||
Comment 1•8 years ago
|
||
Bryan, I presume that "Bookmark This Page" should behave like the current menu item of the same name in the main menu bar? i.e.:
(1) If the current page isn't bookmarked, the label reads, "Bookmark This Page". If the page is bookmarked, the label reads, "Edit This Bookmark".
(2) In either case, when you click the item, the bookmark panel opens.
(3) When the page is bookmarked, do you want to use the filled star image, or should we always use the outlined star image?
Flags: needinfo?(bbell)
Comment 2•8 years ago
|
||
(In reply to Drew Willcoxon :adw from comment #1)
> Bryan, I presume that "Bookmark This Page" should behave like the current
> menu item of the same name in the main menu bar? i.e.:
That's right, the behavior should be the same for items in the Action Menu and in the toolbar.
> (1) If the current page isn't bookmarked, the label reads, "Bookmark This
> Page". If the page is bookmarked, the label reads, "Edit This Bookmark".
Yep.
> (2) In either case, when you click the item, the bookmark panel opens.
>
> (3) When the page is bookmarked, do you want to use the filled star image,
> or should we always use the outlined star image?
If it's bookmarked, we should show the filled-in star.
Flags: needinfo?(bbell)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•8 years ago
|
||
I'd like to break this bug into a bookmark bug and a Pocket bug, in the interest of not blocking the bookmark part on the Pocket part. The Pocket part is a little harder since it's an extension.
I'll make this bug the bookmark bug.
Summary: Add "save to pocket" and "bookmark" items to the page action menu → Add a "bookmark" items to the page action menu
Assignee | ||
Comment 5•8 years ago
|
||
I filed bug 1367927 for Pocket.
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8871518 [details]
Bug 1363183 - Add a "bookmark" item to the page action menu.
https://reviewboard.mozilla.org/r/142986/#review147020
Well, this is just awesomeness in go! Fun to have this one in before the weekend ;-)
Nice work!
Attachment #8871518 -
Flags: review?(mdeboer) → review+
Assignee | ||
Comment 7•8 years ago
|
||
Thanks Mike. Try looks good, landing.
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ddfc6dc2fe67
Add a "bookmark" item to the page action menu. r=mikedeboer
Assignee | ||
Updated•8 years ago
|
Summary: Add a "bookmark" items to the page action menu → Add a "bookmark" item to the page action menu
Comment 9•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 10•8 years ago
|
||
I can see this feature implemented on latest nightly 55.0a1 in Windows 8.1, 64 bit
Build ID 20170531030204
User Agent Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0
[bugday-20170531]
Comment 11•8 years ago
|
||
Verified on Windows, Mac, and Ubuntu on newest Nightly.
Comment 12•7 years ago
|
||
With Bug 1352120, we have a bookmark-star button in the location bar. I think we should remove bookmark item in the page action menu because those are the duplicate feature.
Assignee | ||
Comment 13•7 years ago
|
||
It's going to be in both the menu and urlbar by default. You'll be able to open a context menu inside the menu and add/remove each item to the urlbar as you'd like.
You need to log in
before you can comment on or make changes to this bug.
Description
•