1363295 - stylo: fix the serialization of image-orientation property

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Jeremy Chen ([e-mail])]

I'll work on this and try to remove the whole section of image-orientation in stylo-failures.md.

Comment 1

[Jeremy Chen ([e-mail])]

try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2fed956266542a4d6b4faab1a62aaeef8ba7ab02

Comment 2

[Jeremy Chen ([e-mail])]

Attachment: Bug 1363295 - stylo: update test expectations for image-orientation property.

Review commit: https://reviewboard.mozilla.org/r/137400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137400/

Comment 3

[Jeremy Chen ([e-mail])]

Attachment: Bug 1363295 - stylo: fix the serialization of image-orientation property.

Review commit: https://reviewboard.mozilla.org/r/137402/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137402/

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8865779 [details]
Bug 1363295 - stylo: fix the serialization of image-orientation property.

https://reviewboard.mozilla.org/r/137402/#review140480

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8865778 [details]
Bug 1363295 - stylo: update test expectations for image-orientation property.

https://reviewboard.mozilla.org/r/137400/#review140482

Comment 6

[Jeremy Chen ([e-mail])]

servo PR: https://github.com/servo/servo/pull/16782

Comment 7

[Jeremy Chen ([e-mail])]

Comment on attachment 8865778 [details]
Bug 1363295 - stylo: update test expectations for image-orientation property.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137400/diff/1-2/

Comment 8

[Jeremy Chen ([e-mail])]

PR has been merged to autoland: https://hg.mozilla.org/integration/autoland/rev/b8dc0262c14b

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fb937063a6b
stylo: update test expectations for image-orientation property. r=heycam

Comment 10

[Gregory Szorc [:gps]]

Through no fault of yours, changeset 6fb937063a6b referenced by comment #9 got caught up in servo vcs breakage and had to be dropped from the autoland repo. You will need to reland that changeset.

Note that some Servo Git commits have been removed from the autoland repo, so this changeset may not be appropriate to land until after servo vcs sync is repaired. That is being tracked in bug 1363635.

If you would like me to reland this changeset for you, needinfo me and I'll do that once servo vcs sync is back online.

Comment 11

[Jeremy Chen ([e-mail])]

Thanks for the notice. That could explain why autoland responded very slowly this morning while I tried to land changeset 6fb937063a6b referenced by comment #9.

Please re-land this changeset for me once the servo part is re-merged to autoland. Thank you.

Comment 12

[Jeremy Chen ([e-mail])]

To be more specific, following two changesets (quoted from bug 1363635 comment 8) should be re-landed together, so we could resolve this bug.

b8dc0262c14b	servo: Merge #16782 - Fix the serialization of image-orientation property (from chenpighead:stylo-serialization-of-image-orientation); r=nox
6fb937063a6b	Bug 1363295 - stylo: update test expectations for image-orientation property. r=heycam

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29d31be523f1
stylo: update test expectations for image-orientation property. r=heycam

Comment 14

[Gregory Szorc [:gps]]

Relanding complete.

Comment 15

[Jeremy Chen ([e-mail])]

Gregory, thank you for the help. :-)

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/29d31be523f1