Closed
Bug 1363318
Opened 8 years ago
Closed 8 years ago
Label runnables in dom/fetch
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: bevis, Assigned: bevis)
References
Details
(Whiteboard: [QDL][TDC-MVP][DOM])
Attachments
(3 files)
3.11 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
11.20 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
6.18 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
NS_DispatchToMainThread, NS_ReleaseOnMainThread and MutableBlobStreamListener are used in dom/fetch:
http://searchfox.org/mozilla-central/search?q=Dispatch%7CAsyncWait%7CTimer%7CAbstractThread%7CProxyRelease%7CReleaseOnMainThread%7CMutableBlobStreamListener&case=false®exp=true&path=dom%2Ffetch
The idea to support labeling in dom/fetch is to hold an nsIEventTarget at FetchRequest() either from
1. nsIGlobalObject::EventTargetFor() if NS_IsMainThread() is true, or
2. WorkerPrivate::MainThreadEventTarget(), otherwise,
for the runnables to be dispatched later.
File this bug for the tracking in dom/fetch.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
The use of NS_NewInputStreamPump() requires nsIEventTarget for labeling runnables dispatched internally after bug 1352176 is landed:
http://searchfox.org/mozilla-central/rev/d66b9f27d5630a90b2fce4d70d4e9050f43df9b4/dom/fetch/Fetch.cpp#1261
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8868366 -
Flags: review?(amarchesini)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8868367 -
Flags: review?(amarchesini)
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8868368 -
Flags: review?(amarchesini)
Assignee | ||
Comment 5•8 years ago
|
||
Treeherder result looks fine:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c454fcd114f585eb7b2d25fddfaf125ced5b3b2
Assignee | ||
Updated•8 years ago
|
Whiteboard: [QDL][DOM][TDC-MVP]
Updated•8 years ago
|
Whiteboard: [QDL][DOM][TDC-MVP] → [QDL][TDC-MVP][DOM]
Updated•8 years ago
|
Attachment #8868366 -
Flags: review?(amarchesini) → review+
Updated•8 years ago
|
Attachment #8868367 -
Flags: review?(amarchesini) → review+
Comment 6•8 years ago
|
||
Comment on attachment 8868368 [details] [diff] [review]
(v1) Part 3: Label FetchDriver.
Review of attachment 8868368 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/fetch/Fetch.cpp
@@ +280,5 @@
> NS_WARNING("Aborting Fetch because worker already shut down");
> return NS_OK;
> }
>
> + WorkerPrivate* worker = proxy->GetWorkerPrivate();
call it workerPrivate
Attachment #8868368 -
Flags: review?(amarchesini) → review+
Pushed by btseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d343ee1e22d2
Part 1: Label FetchSignalProxy. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e90e289c6f6
Part 2: Label FetchBody. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cc412eac382
Part 3: Label FetchDriver. r=baku
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d343ee1e22d2
https://hg.mozilla.org/mozilla-central/rev/5e90e289c6f6
https://hg.mozilla.org/mozilla-central/rev/8cc412eac382
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•