1363318 - Label runnables in dom/fetch

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

NS_DispatchToMainThread, NS_ReleaseOnMainThread and MutableBlobStreamListener are used in dom/fetch:
http://searchfox.org/mozilla-central/search?q=Dispatch%7CAsyncWait%7CTimer%7CAbstractThread%7CProxyRelease%7CReleaseOnMainThread%7CMutableBlobStreamListener&case=false&regexp=true&path=dom%2Ffetch

The idea to support labeling in dom/fetch is to hold an nsIEventTarget at FetchRequest() either from 
1. nsIGlobalObject::EventTargetFor() if NS_IsMainThread() is true, or
2. WorkerPrivate::MainThreadEventTarget(), otherwise,
for the runnables to be dispatched later.

File this bug for the tracking in dom/fetch.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

The use of NS_NewInputStreamPump() requires nsIEventTarget for labeling runnables dispatched internally after bug 1352176 is landed:
http://searchfox.org/mozilla-central/rev/d66b9f27d5630a90b2fce4d70d4e9050f43df9b4/dom/fetch/Fetch.cpp#1261

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Part 1: Label FetchSignalProxy.

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Part 2: Label FetchBody.

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Part 3: Label FetchDriver.

Comment 5

[Bevis Tseng[:bevis][:btseng](Exited)]

Treeherder result looks fine:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c454fcd114f585eb7b2d25fddfaf125ced5b3b2

Comment 6

[Andrea Marchesini [:baku]]

Comment on attachment 8868368 [details] [diff] [review]
(v1) Part 3: Label FetchDriver.

Review of attachment 8868368 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/fetch/Fetch.cpp
@@ +280,5 @@
>          NS_WARNING("Aborting Fetch because worker already shut down");
>          return NS_OK;
>        }
>  
> +      WorkerPrivate* worker = proxy->GetWorkerPrivate();

call it workerPrivate

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d343ee1e22d2
Part 1: Label FetchSignalProxy. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e90e289c6f6
Part 2: Label FetchBody. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cc412eac382
Part 3: Label FetchDriver. r=baku

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d343ee1e22d2
https://hg.mozilla.org/mozilla-central/rev/5e90e289c6f6
https://hg.mozilla.org/mozilla-central/rev/8cc412eac382