Closed Bug 1363318 Opened 8 years ago Closed 8 years ago

Label runnables in dom/fetch

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bevis, Assigned: bevis)

References

Details

(Whiteboard: [QDL][TDC-MVP][DOM])

Attachments

(3 files)

NS_DispatchToMainThread, NS_ReleaseOnMainThread and MutableBlobStreamListener are used in dom/fetch: http://searchfox.org/mozilla-central/search?q=Dispatch%7CAsyncWait%7CTimer%7CAbstractThread%7CProxyRelease%7CReleaseOnMainThread%7CMutableBlobStreamListener&case=false&regexp=true&path=dom%2Ffetch The idea to support labeling in dom/fetch is to hold an nsIEventTarget at FetchRequest() either from 1. nsIGlobalObject::EventTargetFor() if NS_IsMainThread() is true, or 2. WorkerPrivate::MainThreadEventTarget(), otherwise, for the runnables to be dispatched later. File this bug for the tracking in dom/fetch.
Blocks: Labeling
Depends on: 1362944
The use of NS_NewInputStreamPump() requires nsIEventTarget for labeling runnables dispatched internally after bug 1352176 is landed: http://searchfox.org/mozilla-central/rev/d66b9f27d5630a90b2fce4d70d4e9050f43df9b4/dom/fetch/Fetch.cpp#1261
Attachment #8868367 - Flags: review?(amarchesini)
Attachment #8868368 - Flags: review?(amarchesini)
Whiteboard: [QDL][DOM][TDC-MVP]
Whiteboard: [QDL][DOM][TDC-MVP] → [QDL][TDC-MVP][DOM]
Attachment #8868366 - Flags: review?(amarchesini) → review+
Attachment #8868367 - Flags: review?(amarchesini) → review+
Comment on attachment 8868368 [details] [diff] [review] (v1) Part 3: Label FetchDriver. Review of attachment 8868368 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/fetch/Fetch.cpp @@ +280,5 @@ > NS_WARNING("Aborting Fetch because worker already shut down"); > return NS_OK; > } > > + WorkerPrivate* worker = proxy->GetWorkerPrivate(); call it workerPrivate
Attachment #8868368 - Flags: review?(amarchesini) → review+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: