Closed Bug 1363395 Opened 7 years ago Closed 7 years ago

Crash in nsGlobalWindow::Location

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Version:
55 Branch
Platform:
Unspecified
Windows 10
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- fixed

People

(Reporter: calixte, Assigned: baku)

References

(Blocks 1 open bug)

Details

(Keywords: crash, regression, Whiteboard: [clouseau])

Crash Data

Attachments

(1 file, 2 obsolete files)

crash1.patch
7.28 KB, patch
smaug
: review+
Details | Diff | Splinter Review 
This bug was filed from the Socorro interface and is 
report bp-0a57cec6-33e6-4415-be44-157120170509.
=============================================================

There are 2 crahes from the same installation in nightly 55 with buildid 20170509030205. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix 1362003.

[1] https://hg.mozilla.org/mozilla-central/rev?node=9e2bc7a6959b2b9de8bfec2370c66e1d3a6d0cdc
Flags: needinfo?(amarchesini)
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attached patch crash1.patch (obsolete) — — Splinter Review 

        Attachment #8865880 -
        Flags: review?(bugs)

    
    

    
  
Comment on attachment 8865880 [details] [diff] [review]
crash1.patch

The name of the method is now wrong. It should be GetLocation() since it may return null.

        Attachment #8865880 -
        Flags: review?(bugs) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        crash1.patch (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #8865880 -
        Attachment is obsolete: true

        Attachment #8865927 -
        Flags: review?(bugs)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        crash1.patch
        — 
          — Splinter Review
      

    


  

        Attachment #8865927 -
        Attachment is obsolete: true

        Attachment #8865927 -
        Flags: review?(bugs)

        Attachment #8865928 -
        Flags: review?(bugs)

        Attachment #8865928 -
        Flags: review?(bugs) → review+

    
    

    
  
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfa904c74509
nsGlobalWindow::GetLocation should support to be called on the outer window, r=smaug

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/dfa904c74509
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox55:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: