Closed Bug 1362003 Opened 3 years ago Closed 3 years ago
Global Window::Get Location doesn't need to receive an Error Result param
No description provided.
Would be nice to get rid of nsIDOMLocation completely. Maybe as follow up.
Assignee: nobody → amarchesini
Attachment #8864480 - Flags: review?(bzbarsky)
Comment on attachment 8864480 [details] [diff] [review] location2.patch >+ [PutForwards=href, Unforgeable, BinaryName="getLocation", Why the BinaryName instead of just renaming the getter to Location() on the C++ side?
Attachment #8864480 - Flags: review?(bzbarsky) → review-
Comment on attachment 8864814 [details] [diff] [review] location2.patch After this, the only consumers of nsIDOMLocation are devtools/server/actors/object.js and nsIDOMDocument bits, right? Do you mind filing a followup to either remove nsIDOMLocation altogether or at least make it an empty interface? r=me
Attachment #8864814 - Flags: review?(bzbarsky) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9e2bc7a6959b nsGlobalWindow::GetLocation doesn't need to receive an ErrorResult param, r=bz
You need to log in before you can comment on or make changes to this bug.