All users were logged out of Bugzilla on October 13th, 2018

nsGlobalWindow::GetLocation doesn't need to receive an ErrorResult param

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: baku, Assigned: baku)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8864480 [details] [diff] [review]
location2.patch

Would be nice to get rid of nsIDOMLocation completely. Maybe as follow up.
Assignee: nobody → amarchesini
Attachment #8864480 - Flags: review?(bzbarsky)
Comment on attachment 8864480 [details] [diff] [review]
location2.patch

>+  [PutForwards=href, Unforgeable, BinaryName="getLocation",

Why the BinaryName instead of just renaming the getter to Location() on the C++ side?
Attachment #8864480 - Flags: review?(bzbarsky) → review-
(Assignee)

Comment 3

2 years ago
Created attachment 8864814 [details] [diff] [review]
location2.patch
Attachment #8864480 - Attachment is obsolete: true
Attachment #8864814 - Flags: review?(bzbarsky)
Comment on attachment 8864814 [details] [diff] [review]
location2.patch

After this, the only consumers of nsIDOMLocation are devtools/server/actors/object.js and nsIDOMDocument bits, right?  Do you mind filing a followup to either remove nsIDOMLocation altogether or at least make it an empty interface?

r=me
Attachment #8864814 - Flags: review?(bzbarsky) → review+

Comment 5

2 years ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e2bc7a6959b
nsGlobalWindow::GetLocation doesn't need to receive an ErrorResult param, r=bz
(Assignee)

Updated

2 years ago
Blocks: 1363057

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9e2bc7a6959b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1363395
You need to log in before you can comment on or make changes to this bug.