1362003 - nsGlobalWindow::GetLocation doesn't need to receive an ErrorResult param

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: location2.patch

Would be nice to get rid of nsIDOMLocation completely. Maybe as follow up.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8864480 [details] [diff] [review]
location2.patch

>+  [PutForwards=href, Unforgeable, BinaryName="getLocation",

Why the BinaryName instead of just renaming the getter to Location() on the C++ side?

Comment 3

[Andrea Marchesini [:baku]]

Attachment: location2.patch

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8864814 [details] [diff] [review]
location2.patch

After this, the only consumers of nsIDOMLocation are devtools/server/actors/object.js and nsIDOMDocument bits, right?  Do you mind filing a followup to either remove nsIDOMLocation altogether or at least make it an empty interface?

r=me

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e2bc7a6959b
nsGlobalWindow::GetLocation doesn't need to receive an ErrorResult param, r=bz

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9e2bc7a6959b