If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Awesome bar results and one-off buttons have different blue shades on keyboard selection

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Address Bar
P1
normal
VERIFIED FIXED
5 months ago
5 months ago

People

(Reporter: alindeac, Assigned: adw)

Tracking

55 Branch
Firefox 55
All
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 disabled, firefox54 disabled, firefox55 verified)

Details

(Whiteboard: [fxsearch])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Created attachment 8865888 [details]
DifferentBlueShades.png

[Affected versions]:
- Nightly 55.0a1

[Affected platforms]:
- Windows and Mac OS X

[Steps to reproduce]:
1. Launch Firefox
2. Type "moz" in the URL bar
3. Press Down arrow key until you reach the last awesome bar result (right above the one-offs bar)
4. Press ALT+ UP arrow keys to focus one one-off button
5. Observe the 2 key selections 

[Expected result]:
- The 2 selections should have the same color.

[Actual result]:
- The 2 selections have different shades of blue. 

[Notes]:
If I set the preference browser.urlbar.oneOffSearches to true this issue is reproducible also in Firefox 51.
Drew is this on purpose? Are we using a system color perhaps?
Flags: needinfo?(adw)
Whiteboard: [fxsearch]
We're using a hardcoded color for the list items and Highlight for the one-offs.  I guess they should both use Highlight.

List items: https://dxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.css#860

One-offs: https://dxr.mozilla.org/mozilla-central/source/browser/themes/osx/searchbar.css#210
Flags: needinfo?(adw)

Comment 3

5 months ago
(In reply to Drew Willcoxon :adw from comment #2)
> We're using a hardcoded color for the list items and Highlight for the
> one-offs.  I guess they should both use Highlight.

Yep, I agree.
Comment hidden (mozreview-request)
On Linux, we're already using Highlight: https://dxr.mozilla.org/mozilla-central/source/browser/themes/linux/browser.css#679

Comment 6

5 months ago
mozreview-review
Comment on attachment 8866588 [details]
Bug 1363407 - Awesome bar results and one-off buttons have different blue shades on keyboard selection.

https://reviewboard.mozilla.org/r/138194/#review141402

::: browser/themes/windows/browser.css:1414
(Diff revision 1)
>    font: message-box;
>    border-radius: 2px;
>    border: 1px solid transparent;
>  }
>  
> +.autocomplete-richlistitem[selected] {

I suspect the .autocomplete-richlistitem:hover will now unintentionally override this since you changed the order.

Comment 7

5 months ago
mozreview-review
Comment on attachment 8866588 [details]
Bug 1363407 - Awesome bar results and one-off buttons have different blue shades on keyboard selection.

https://reviewboard.mozilla.org/r/138194/#review141672
Attachment #8866588 - Flags: review?(dao+bmo)
Comment hidden (mozreview-request)
Yep, thanks.

Comment 10

5 months ago
mozreview-review
Comment on attachment 8866588 [details]
Bug 1363407 - Awesome bar results and one-off buttons have different blue shades on keyboard selection.

https://reviewboard.mozilla.org/r/138194/#review141692

::: browser/themes/windows/browser.css:1445
(Diff revision 2)
>  @media (-moz-windows-default-theme) {
>    .autocomplete-richlistitem:hover,
>    treechildren.searchbar-treebody::-moz-tree-row(hover) {
>      background-color: hsla(0, 0%, 0%, 0.06);
>      border-color: hsla(0, 0%, 0%, 0.1);
>    }

Some kind of hover feedback for non-default themes would be nice. Can you move this outside of the media block and use --arrowpanel-dimmed?
Attachment #8866588 - Flags: review?(dao+bmo) → review+
Comment hidden (mozreview-request)
Done

Comment 13

5 months ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 7261ebbfac3b -d c79085f94c57: rebasing 395252:7261ebbfac3b "Bug 1363407 - Awesome bar results and one-off buttons have different blue shades on keyboard selection. r=dao" (tip)
merging browser/themes/osx/browser.css
merging browser/themes/shared/toolbarbuttons.inc.css and browser/themes/windows/browser.css to browser/themes/shared/toolbarbuttons.inc.css
merging browser/themes/windows/browser.css
warning: conflicts while merging browser/themes/shared/toolbarbuttons.inc.css! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request)

Comment 15

5 months ago
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18afc87e7a68
Awesome bar results and one-off buttons have different blue shades on keyboard selection. r=dao

Comment 16

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/18afc87e7a68
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Blocks: 1363692

Updated

5 months ago
Assignee: nobody → adw

Comment 17

5 months ago
I have reproduced this bug with Nightly 55.0a1 (2017-05-09) on Windows 10, 64 bit!

The fix is now verified on Latest Nightly

Build ID 	20170516122050
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170517]
Thanks!
Status: RESOLVED → VERIFIED

Updated

5 months ago
Priority: -- → P1
Verified as fixed also on Mac OS X 10.12 (Build ID: 20170518030213). Setting the firefox55 tracking flag to verified.
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.