1363521 - Crash in java.lang.UnsupportedOperationException: This isn''t a hierarchical URI. at android.net.Uri.getQueryParameterNames(Uri.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P2)

Description

[Max Liu [:maliu]]

This bug was filed from the Socorro interface and is 
report bp-61d3eb89-64f0-43dc-93fe-56f6e0170508.
=============================================================

java.lang.UnsupportedOperationException: This isn't a hierarchical URI.
	at android.net.Uri.getQueryParameterNames(Uri.java:1572)
	at org.mozilla.gecko.activitystream.ranking.HighlightCandidate.extractFeatures(HighlightCandidate.java:131)
	at org.mozilla.gecko.activitystream.ranking.HighlightCandidate.fromCursor(HighlightCandidate.java:51)
	at org.mozilla.gecko.activitystream.ranking.HighlightsRanking$1.call(HighlightsRanking.java:100)
	at org.mozilla.gecko.activitystream.ranking.HighlightsRanking$1.call(HighlightsRanking.java:97)
	at org.mozilla.gecko.activitystream.ranking.RankingUtils.mapCursor(RankingUtils.java:164)
	at org.mozilla.gecko.activitystream.ranking.HighlightsRanking.extractFeatures(HighlightsRanking.java:97)
	at org.mozilla.gecko.activitystream.ranking.HighlightsRanking.rank(HighlightsRanking.java:73)
	at org.mozilla.gecko.activitystream.homepanel.HighlightsLoader.loadInBackground(HighlightsLoader.java:64)
	at org.mozilla.gecko.activitystream.homepanel.HighlightsLoader.loadInBackground(HighlightsLoader.java:26)

The URI is "jar:file:///data/user/0/org.mozilla.fennec" that cause the crash in activity-stream, which is from switchboard add-on. Possible a regression because the URI was "about:experiments".

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Sebastian, want to take this one?

Comment 2

[:Grisha Kruglov]

Attachment: Bug 1363521 - Pre: update comment describing current state of bookmark creation date

Review commit: https://reviewboard.mozilla.org/r/154678/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154678/

Comment 3

[:Grisha Kruglov]

Attachment: Bug 1363521 - Extract query length only for hierarchical uris during highlights ranking

Review commit: https://reviewboard.mozilla.org/r/154680/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154680/

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8883750 [details]
Bug 1363521 - Pre: update comment describing current state of bookmark creation date

https://reviewboard.mozilla.org/r/154678/#review159838

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8883750 [details]
Bug 1363521 - Pre: update comment describing current state of bookmark creation date

https://reviewboard.mozilla.org/r/154678/#review159840

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8883751 [details]
Bug 1363521 - Extract query length only for hierarchical uris during highlights ranking

https://reviewboard.mozilla.org/r/154680/#review159842

This definitely fixes the crash. But I wonder whether we should filter non http(s) URLs out from highlights completely.

Comment 7

[:Grisha Kruglov]

(In reply to Sebastian Kaspari (:sebastian) from comment #6)
> This definitely fixes the crash. But I wonder whether we should filter non
> http(s) URLs out from highlights completely.

Probably we should, yeah. I'm happy to not have it crash for now. Filed Bug 1378890.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7fd8b4bc028
Pre: update comment describing current state of bookmark creation date r=sebastian
https://hg.mozilla.org/integration/autoland/rev/db0c3c9bc5c4
Extract query length only for hierarchical uris during highlights ranking r=sebastian

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e7fd8b4bc028
https://hg.mozilla.org/mozilla-central/rev/db0c3c9bc5c4

Comment 10

[Chris Peterson [:cpeterson]]

Removing regressionwindow-wanted keyword because this bug has been resolved.

Comment 11

[Chris Peterson [:cpeterson]]

Removing regressionwindow-wanted keyword because this bug has been resolved.