stylo: Support dynamic changes to @counter-style rules

RESOLVED FIXED in Firefox 55

Status

()

Core
CSS Parsing and Computation
P2
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

(Blocks: 3 bugs)

53 Branch
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
For some failures after bug 1328319 gets fixed.
Priority: -- → P2
(Assignee)

Comment 1

2 months ago
I thought we may need something equivalent to Gecko's CSSStyleSheet::SetModifiedByChildRule(), but it seems it is unnecessary, and bug 1364871 actually completely fixed this issue. Dynamic changes to @counter-style rules now work as expected.

There are several assertions recorded, but those assertions were added intentionally to notice where the problem could be. If there is no longer any problem, we can simply remove the assertions.
Depends on: 1364871
(Assignee)

Updated

2 months ago
Assignee: nobody → xidorn+moz
Comment hidden (mozreview-request)

Comment 3

2 months ago
mozreview-review
Comment on attachment 8871625 [details]
Bug 1363590 - Remove the assertions for dynamic change of @counter-style.

https://reviewboard.mozilla.org/r/143124/#review146844

r=me.

This works because we re-resolve the style when restyling the element. It's not clear we need to optimize this, but if we needed to, we'd notice the failures.
Attachment #8871625 - Flags: review?(emilio+bugs) → review+

Comment 4

2 months ago
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/653150c581ff
Remove the assertions for dynamic change of @counter-style. r=emilio

Comment 5

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/653150c581ff
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.