Closed
Bug 1363590
Opened 7 years ago
Closed 7 years ago
stylo: Support dynamic changes to @counter-style rules
Categories
(Core :: CSS Parsing and Computation, enhancement, P2)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(1 file)
For some failures after bug 1328319 gets fixed.
|
||
Updated•7 years ago
|
Priority: -- → P2
|
Assignee | |
Comment 1•7 years ago
|
||
I thought we may need something equivalent to Gecko's CSSStyleSheet::SetModifiedByChildRule(), but it seems it is unnecessary, and bug 1364871 actually completely fixed this issue. Dynamic changes to @counter-style rules now work as expected. There are several assertions recorded, but those assertions were added intentionally to notice where the problem could be. If there is no longer any problem, we can simply remove the assertions.
Depends on: 1364871
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → xidorn+moz
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8871625 [details] Bug 1363590 - Remove the assertions for dynamic change of @counter-style. https://reviewboard.mozilla.org/r/143124/#review146844 r=me. This works because we re-resolve the style when restyling the element. It's not clear we need to optimize this, but if we needed to, we'd notice the failures.
Attachment #8871625 -
Flags: review?(emilio+bugs) → review+
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/653150c581ff Remove the assertions for dynamic change of @counter-style. r=emilio
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/653150c581ff
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•