1363596 - stylo: Support symbols() function and string value for list-style-type

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Will working on this after bug 1328319 lands.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0fa4f79e2489ff9b4b6de03bdd50add852f97bb2

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1363596 part 1 - Merge nsCOMPtr<nsIAtom> into CounterStylePtr.

Review commit: https://reviewboard.mozilla.org/r/143014/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143014/

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1363596 part 2 - Add support for symbols() function.

Review commit: https://reviewboard.mozilla.org/r/143016/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143016/

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1363596 part 3 - Add string support for list-style-type.

Review commit: https://reviewboard.mozilla.org/r/143018/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143018/

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8871543 [details]
Bug 1363596 part 2 - Add support for symbols() function.

https://reviewboard.mozilla.org/r/143016/#review146726

::: layout/style/ServoBindings.cpp:1145
(Diff revision 1)
> +                               uint32_t aSymbolsCount)
> +{
> +  nsTArray<nsString> symbols(aSymbolsCount);
> +  for (uint32_t i = 0; i < aSymbolsCount; i++) {
> +    nsString* symbol = symbols.AppendElement();
> +    AppendUTF8toUTF16(*aSymbols[i], *symbol);

There is still a hazard from this that:
```
[27.28s] #97 Analyzing Gecko_SetCounterStyleToSymbols ...
Error: Field write mozilla::detail::nsStringRepr.mLength nsAString.field:0
Location: _ZN9nsAString9SetLengthEj$void nsAString::SetLength(uint32) @ xpcom/string/nsTSubstring.cpp#730
Stack Trace:
_Z17AppendUTF8toUTF16RK10nsACStringR9nsAStringRKN7mozilla10fallible_tE$uint8 AppendUTF8toUTF16(nsACString*, nsAString*, mozilla::fallible_t*) @ xpcom/string/nsReadableUtils.cpp#381
_Z17AppendUTF8toUTF16RK10nsACStringR9nsAString$void AppendUTF8toUTF16(nsACString*, nsAString*) @ xpcom/string/nsReadableUtils.cpp#344
Gecko_SetCounterStyleToSymbols @ layout/style/ServoBindings.cpp#1145 ### SafeArguments: <arg0>
```

And I have no idea what should I do with it...

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8871543 [details]
Bug 1363596 part 2 - Add support for symbols() function.

https://reviewboard.mozilla.org/r/143016/#review146726

> There is still a hazard from this that:
> ```
> [27.28s] #97 Analyzing Gecko_SetCounterStyleToSymbols ...
> Error: Field write mozilla::detail::nsStringRepr.mLength nsAString.field:0
> Location: _ZN9nsAString9SetLengthEj$void nsAString::SetLength(uint32) @ xpcom/string/nsTSubstring.cpp#730
> Stack Trace:
> _Z17AppendUTF8toUTF16RK10nsACStringR9nsAStringRKN7mozilla10fallible_tE$uint8 AppendUTF8toUTF16(nsACString*, nsAString*, mozilla::fallible_t*) @ xpcom/string/nsReadableUtils.cpp#381
> _Z17AppendUTF8toUTF16RK10nsACStringR9nsAString$void AppendUTF8toUTF16(nsACString*, nsAString*) @ xpcom/string/nsReadableUtils.cpp#344
> Gecko_SetCounterStyleToSymbols @ layout/style/ServoBindings.cpp#1145 ### SafeArguments: <arg0>
> ```
> 
> And I have no idea what should I do with it...

I think I have a solution now...

Comment 8

[Cameron McCormack (:heycam)]

Comment on attachment 8871542 [details]
Bug 1363596 part 1 - Merge nsCOMPtr<nsIAtom> into CounterStylePtr.

https://reviewboard.mozilla.org/r/143014/#review146808

Comment 9

[Cameron McCormack (:heycam)]

Comment on attachment 8871543 [details]
Bug 1363596 part 2 - Add support for symbols() function.

https://reviewboard.mozilla.org/r/143016/#review146810

::: layout/style/CounterStyleManager.h:107
(Diff revision 1)
>  
>  class AnonymousCounterStyle final : public CounterStyle
>  {
>  public:
>    explicit AnonymousCounterStyle(const nsSubstring& aContent);
> +  AnonymousCounterStyle(uint8_t aSystem, nsTArray<nsString> aSymbols);

Should the second argument be nsTArray<nsString>&&?

::: servo/components/style/gecko/values.rs:416
(Diff revision 1)
> +                let symbols: Vec<_> = symbols.0.iter().map(|symbol| match *symbol {
> +                    Symbol::String(ref s) => nsCString::from(s),
> +                    Symbol::Ident(_) => unreachable!("Should not have identifier in symbols()"),
> +                }).collect();
> +                let symbols: Vec<_> = symbols.iter().map(|symbol| {
> +                    symbol as &nsACString as *const nsACString

"as *const _" if you want to bit a bit shorter.

Comment 10

[Cameron McCormack (:heycam)]

Comment on attachment 8871544 [details]
Bug 1363596 part 3 - Add string support for list-style-type.

https://reviewboard.mozilla.org/r/143018/#review146814

Comment 11

[Xidorn Quan [:xidorn] UTC+10]

Servo side: servo/servo#17060

Comment 12

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8871543 [details]
Bug 1363596 part 2 - Add support for symbols() function.

https://reviewboard.mozilla.org/r/143016/#review146810

> Should the second argument be nsTArray<nsString>&&?

Not necessary as far as callsites use `Move`. Might be better using `&&` to avoid accidental copy, though...

Comment 13

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8871542 [details]
Bug 1363596 part 1 - Merge nsCOMPtr<nsIAtom> into CounterStylePtr.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143014/diff/1-2/

Comment 14

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8871543 [details]
Bug 1363596 part 2 - Add support for symbols() function.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143016/diff/1-2/

Comment 15

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8871544 [details]
Bug 1363596 part 3 - Add string support for list-style-type.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143018/diff/1-2/

Comment 16

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s f8256885e1be -d 1ff36fd81097: rebasing 398629:f8256885e1be "Bug 1363596 part 1 - Merge nsCOMPtr<nsIAtom> into CounterStylePtr. r=heycam"
rebasing 398630:7eccc8ee6a73 "Bug 1363596 part 2 - Add support for symbols() function. r=heycam"
merging layout/reftests/counter-style/reftest.list
warning: conflicts while merging layout/reftests/counter-style/reftest.list! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05b6b590129d
part 1 - Merge nsCOMPtr<nsIAtom> into CounterStylePtr. r=heycam
https://hg.mozilla.org/integration/autoland/rev/bfb3d68ed8c4
part 2 - Add support for symbols() function. r=heycam
https://hg.mozilla.org/integration/autoland/rev/9fcbe35118f1
part 3 - Add string support for list-style-type. r=heycam

Comment 18

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/05b6b590129d
https://hg.mozilla.org/mozilla-central/rev/bfb3d68ed8c4
https://hg.mozilla.org/mozilla-central/rev/9fcbe35118f1