1363612 - Use a separate HTML instead of using inline data: URI

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

For following tests they either use window.location or window.open some data: URI, however this will fail once we turn off security.data_uri.inherit_security_contex

    dom/base/test/test_bug426646.html

    dom/tests/mochitest/dom-level0/test_location_setters.html

    dom/broadcastchannel/tests/test_bfcache.html

    dom/tests/mochitest/bugs/test_bug369306.html

    dom/tests/mochitest/bugs/test_bug622361.html  

    dom/tests/mochitest/bugs/test_sizetocontent_clamp.html

    dom/xbl/test/test_bug310107.html

    dom/xml/test/test_bug691215.html

I'll make them use a seperate file in this bug.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: move to seperate files

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: move files for bug 677495

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: fix for moz-binding: url

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 4: revise test_bug518104_html

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8867072 [details] [diff] [review]
Part 1: move to seperate files

>   function checkForLoad(win) {
>     if (!win.document.documentElement ||
>-        win.document.documentElement.textContent != "Loaded") {
>+        win.document.documentElement.innerText != "Loaded") {
oh, is this because we get some more white spaces.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Olli Pettay [:smaug] from comment #6)
> Comment on attachment 8867072 [details] [diff] [review]
> Part 1: move to seperate files
> 
> >   function checkForLoad(win) {
> >     if (!win.document.documentElement ||
> >-        win.document.documentElement.textContent != "Loaded") {
> >+        win.document.documentElement.innerText != "Loaded") {
> oh, is this because we get some more white spaces.

Yes, "\n" more precisely.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8867082 [details] [diff] [review]
Part 4: revise test_bug518104_html

I don't understand this.
Should loading script from data: work just fine. Is there some issue with document.write here?

Please explain and ask review again or fix something.
Please test also how other browsers work.

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Olli Pettay [:smaug] from comment #8)
> Please explain and ask review again or fix something.
> Please test also how other browsers work.
Smaug, you're right.  I'll fix this.

Originally I filed bug 1363629 to fix that test, later I thought it's the same problem with this bug so I duplicated it, now since it is a different problem, I'll reopen it, and post the fix there. 
Thanks

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0e3dc83b335
Part 1: move to seperate files. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/adc78c679f03
Part 2: move files for bug 677495. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/22522049bc80
Part 3: fix for moz-binding: url. r=smaug

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a0e3dc83b335
https://hg.mozilla.org/mozilla-central/rev/adc78c679f03
https://hg.mozilla.org/mozilla-central/rev/22522049bc80