1363689 - Have gBrowser.loadTabs() provide a valid triggeringPrincipal

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1363689_loadtabs_triggeringPrincipal.patch

Gijs, similar to bug 1363687 we would like tests to pass a triggeringPrincipal for loadTabs(). Please note that I also updated tabbrowser.xml to pass on that principal to addTab(...) or also loadURIWithFlags within tabbrowser.xml.

Comment 2

[:Gijs (out for now; he/him)]

Comment on attachment 8866327 [details] [diff] [review]
bug_1363689_loadtabs_triggeringPrincipal.patch

Review of attachment 8866327 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/test/browser_522545.js
@@ +207,5 @@
>        runNextTest();
>      }
>  
> +    gBrowser.loadTabs(uris, {
> +      triggeringPrincipal: Services.scriptSecurityManager.getSystemPrincipal()

nit; trailing comma

::: testing/talos/talos/tests/tabswitch/bootstrap.js
@@ +85,5 @@
>  function loadTabs(gBrowser, urls) {
>    return new Promise((resolve) => {
> +    gBrowser.loadTabs(urls, {
> +      inBackground: true
> +      triggeringPrincipal: Services.scriptSecurityManager.getSystemPrincipal()

Trailing commas missing here and the line before.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c58392f950f
Have gBrowser.loadTabs() provide a valid triggeringPrincipal. r=gijs

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5c58392f950f