1363726 - Should make search keywords be selected after clicking search field again

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Evan Tseng [:evanxd]]

Should make search keywords be selected after clicking search field again. Check the "Click on search field again" in the spec[1].

[1]: https://mozilla.invisionapp.com/share/ZDAGPK3AF#/screens/218928188_5-0_Search_Field.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1363726 - Clicking on the search input should select all text entered into it.

Review commit: https://reviewboard.mozilla.org/r/138124/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138124/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8866493 [details]
Bug 1363726 - Clicking on the search input should select all text entered into it.

https://reviewboard.mozilla.org/r/138124/#review141632

::: commit-message-3446c:1
(Diff revision 1)
> +Bug 1363726 - Add clickSelectsAll attribute in search input r?jaws

The commit message should read:
Bug 1363726 - Clicking on the search input should select all text entered into it. r=jaws

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8866493 [details]
Bug 1363726 - Clicking on the search input should select all text entered into it.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138124/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46bb3ddb379a
Clicking on the search input should select all text entered into it. r=jaws

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/46bb3ddb379a

Comment 6

[Farhadur Reja Fahim]

I have reproduced this bug with Nightly 55.0a1 (2017-05-10) on Ubuntu 16.04, 64 bit!

The bug's fix is now verified on latest Nightly 56.0a1.

Build ID 	20170616100254
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

[bugday 20170614]

Comment 7

[Saddam Hossain]

I have reproduced this Bug on Nightly 55.0a1 (2017-05-10) on Windows 10, 64 Bit!

The bug's fix is now verified on latest  Nightly 56.0a1

Build ID    :	20170616030207
User Agent  : 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

[bugday-20170614]

Comment 8

[Aravind Arul]

Operating System:Windows 10-64-bit
Firefox Version:Nightly 56.0a1

I have tried to reproduce this bug and it cannot be reproduced on latest Firefox nightly browser.
This Bug is no longer available.

[bugday-20170628]

Comment 9

[Hani Yacoub, Desktop QA]

Build ID: 20170706130327
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:56.0) Gecko/20100101 Firefox/56.0

Verified as fixed on Firefox Nightly 56.0a1 on Mac OS X 10.12.