1357285 - [meta] Preferences search

Status: NEW

(Firefox :: Settings UI, enhancement)

Description

[Fischer [:Fischer]]

This is a meta bug to track all bugs that block the shipping of Preferences Search in Photon Preferences.

Comment 1

[Fischer [:Fischer]]

Thanks for the huge part of the search feature works done by Mike, Jared and the MSU students.
Since Photon Preferences plans to ship the search feature, we will join the development as well.
From now on the Photon Preferences will 
  - take on the bug 1357130 and 
  - fix follow-up bugs if reported and
  - continue the works of the bug 1349747, bug 1352481, and bug 1351867 if needed.

The below is the detail email from Mike about the current status and how to collaborate on the search works:
> On Tue, Apr 18, 2017 at 1:03 AM, Mike Conley <[e-mail]> wrote:
> Hey Fischer,
> 
> Thanks for the email.
> 
> The MSU students who have been working on this project are starting to
> wrap up now.
> 
> There's still some work in-flight for the search feature, but I suspect
> given the remaining time (the students are "pencil's down" on April
> 27th) it's unlikely to land in time, and we'll need to do some kind of
> hand-off.
> 
> Here are the big remaining bits:
> 
> * Bug 1349747 - The search box in about:preferences should show search
> suggestions
> ** MSU student manotejmeka has a proof-of-concept patch posted, but (at
> our suggestion), he's using hard-coded strings for things like "stop
> words". This patch might need some re-architecture, and certainly some
> clean-up.
> 
> * Bug 1352481 - Search should find matched strings within popups and
> subdialogs
> ** Similar to the above - manotejmeka has a proof-of-concept patch
> posted, but the code is definitely not in a state that is close to landing.
> 
> * Bug 1351867 - Show search matches in a tooltip pointing at buttons if
> the matched text will be revealed when clicking on the button
> ** Similar to the above. I'm not sure how useful manotejmeka's
> proof-of-concept patch will be as a starting point though, as he appears
> to be doing multiple synchronous reflows when adding the tooltips.
> 
> * Bug 1357130 - Preferences search highlight should match the spec
> ** This is one that hasn't been started yet (I just filed it), and could
> be started immediately by your team.
> 
> There are some smaller bugs blocking bug 1353954 that will likely be
> fixed before the MSU students are done (example: bug 1340643 and bug
> 1353862).
> 
> I should also point out that QA hasn't started to test search, as far as
> I know, so there might be some remaining functional issues that will
> need to be worked out as well that they will find.
> 
> My advice is to start immediately on bug 1357130, and start researching
> better approaches to bug 1349747, bug 1352481, and bug 1351867. We'll
> alert you when the MSU students have completed their term (next week),
> and we can then re-assign the bugs.

Comment 2

[chsiang]

Release Note Request (optional, but appreciated)
[Why is this notable]:New feature 
[Affects Firefox for Android]:No
[Suggested wording]: Added search function under Preferences/ Options
[Links (documentation, blog post, etc)]:N/A

[Tracking Requested - why for this release]:

Comment 3

[nivtwig]

Bug 1296904 seems like a duplicate

Comment 4

[nivtwig]

Bug 1373447 probably should be added as a dependency ?

Comment 6

[Gerry Chang [:gchang]]

The release note was already added in bug 1353954.