Closed Bug 1363785 Opened 4 years ago Closed 4 years ago

Remove anchors from Firefox in-product links that link to SUMO KB articles

Categories

(support.mozilla.org :: Knowledge Base Software, task, P2)

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: jsavage, Assigned: jsavage)

References

Details

Tina Hsieh is reworking the UX for the preferences menu in Firefox desktop. One of our requests is to remove anchor links in the Firefox UI and link to an article instead. 

We already have redirects to anchors in place, but we can remove those redirects before the Firefox version 55 launch.
:giorgos does removing anchor links in lithium break any of your stuff in any way? i don't think so but we need to be 100% sure
Flags: needinfo?(giorgos)
Can you give an example of a link that's being removed and its replacement?
Flags: needinfo?(giorgos)
Flags: needinfo?(rtanglao)
:(In reply to Giorgos Logiotatidis [:giorgos] from comment #2)
> Can you give an example of a link that's being removed and its replacement?

joni please provide giorgos an example of OLD link w/anchor and NEW replacement link without anchor .
Flags: needinfo?(rtanglao) → needinfo?(jsavage)
Hi Giorgos,

Here's an example of an old link with an anchor:

https://support.mozilla.org/kb/Options window - Advanced panel#advanced_encryption

Here's what it should be:

https://support.mozilla.org/kb/advanced-panel-settings-in-firefox


Please need info me if you need anything else.
Flags: needinfo?(jsavage)
Is it worth noting here


The link given as an example is a Kitsune link.
We already know for certain, that links in Kitsune that include a # fragment to link to a sub section of an article will cause issues.
The issues I recall include.  (I am sure there will be one or more bugs filed previously about some of the issues)
Problems with localisation.
Problems with trying to use such links as locale agnostic. 

I believe I would be correct in saying a link with such a # fragment would not break entirely instead it is likely when used in any browser that it will default to the top of the article.


The comment 0 description relates to Lithium.


I am unclear whether this bug relates only to some small number of as yet unspecified but very specific in product links or whether it is of a larger scope possibly removing the feature and use of links to any anchors of sub sections of articles when used within Lithium.  The latter would have very many consequences.  
Even if this is restricted to KB related links will this prevent interlinks from KB articles that link to sub sections and for instance prevent inter linking to sub sections of KB articles, including likely the many hundreds or thousands of such currently existing anchors in sections of kb articles.
If we are only discussing in product links that use # fragments has anyone attempted to identify and list such links, or if a very specific small number of links what are those ?

NI Joni & Roland for clarification and comments please
Flags: needinfo?(rtanglao)
Flags: needinfo?(jsavage)
> Hi Giorgos,
> 
> Here's an example of an old link with an anchor:
> 
> https://support.mozilla.org/kb/Options window - Advanced
> panel#advanced_encryption
> 
> Here's what it should be:
> 
> https://support.mozilla.org/kb/advanced-panel-settings-in-firefox

Joni I see that we have an in product redirect that points to 

  https://support.mozilla.org/kb/Options window - Advanced panel#advanced_encryption

which is

  https://support.mozilla.org/admin/inproduct/redirect/31/


From this In Product Redirect entry I understand that Firefox uses 

  https://support.mozilla.org/1/*/*/*/*/prefs-advanced-encryption

which in Kitsune we turn this into 

  https://support.mozilla.org/kb/Options window - Advanced panel#advanced_encryption

which Kitsune turns this into

  https://support.mozilla.org/kb/advanced-panel-settings-in-firefox


In the bug description you say that one of your asks to the Firefox team is to change the link to another link without anchors but it seems that Firefox does not use anchors in the example your posted. Can you provide some insight?
hi john

1. yup comment 0 refers to Lithium and we are on Kitsune but we are trying to get Lithium to support Kitsune-style in product links.

2. Sorry but I don't understand the rest of your question(s). Kitsune-style in product links are being taken care of by the Lithium SOW. This bug is about Firefox in-product links not all links; I'll change the summary to make that clear.

3. Not sure about links with anchors from one SUMO KB article to another; I think Joni can answer that (and that should be in a separate bug in my opinion). 
Please re-ask your question(s) and a) number them b) be more concise :-) Best would be to first open a thread in the SUMO contributor forum and figure this out there and then file a bug. Or we can talk about it at the platform meeting. Figuring out whether a new bug needs to be filed is best not done in bugzilla.

Cheers!

...Roland
Flags: needinfo?(rtanglao)
Summary: Remove redirects to anchor links in Lithium → Remove anchors from Firefox in-product links that link to SUMO KB articles
Thanks for the clarification Roland.
> ...  This bug is about Firefox in-product links not all links; I'll change the summary to make that clear. ...


A.)  Not sure yet whether this bug is a request to remove
  a.  _all_ anchors from _all_ in-product_ links
  b.  only one or more specific, but unspecified; anchors or links with anchors
I will leave Joni to understand that & the consequences of either of those actions.

B.) Example.  Maybe it would have helped to have given an example of a Lithium link that demonstrates the issue. 

C.) I am happy with the clarification that we are _not_ having a more wide ranging scope of removing anchor links in Lithium.

D.) I was not trying to file another set of bugs. I was seeking clarification of what this bug was describing and intending.
(In reply to Joni Savage ("need info" me) from comment #0)
> Tina Hsieh is reworking the UX for the preferences menu in Firefox desktop.
See also bug 1359735 comment 3.
See Also: → 1359735
See Also: → 1365051
I've take the liberty of assigning it to Joni to get fixed in the June 5 sprint or the sprint after.
Joni please un-assign yourself and assign the right person or change priority if you disagree :-)
Assignee: nobody → jsavage
Status: NEW → ASSIGNED
Priority: -- → P2
See Also: 1359735
Joni, should this bug be closed or moved to the support.mozilla.org product? We aren't switching back to Lithium.
Closing as wont fix, please re-open if you think there's a chance Firefox engineering will ever remove anchors from in-product links
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: needinfo?(jsavage)
Product: support.mozilla.org - Lithium → support.mozilla.org
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.