1363803 - Consolidate YUI js and css into one js and one css file

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, enhancement)

Description

[Dylan Hardison [:dylan] (he/him)]

This reduces the possible variation in CSS and javascript files by a large degree, which simplifies further work on doing content-based asset and asset concatenation.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1363803_1.patch

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1363803_2.patch

Update: handle yui3 as well. 
yui3 is smart enough to detect if js (or css) are already loaded, and if so it doesn't load them dynamically. This means MyDashboard loads with 73 fewer HTTP requests. This won't matter much for HTTP2, but it makes the HTTP/1.1 experience better on the balance.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1363803_3.patch

Have to delay loading the YUI3 constructor due to a bug in YUI3.

Comment 4

[:glob ✱]

Comment on attachment 8866577 [details] [diff] [review]
1363803_3.patch

Review of attachment 8866577 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob lgtm

::: Bugzilla/Install/Filesystem.pm
@@ +582,5 @@
> +                        File::Spec->rel2abs( $url, $from_dir )
> +                    ),
> +                    $to_dir
> +                );
> +                return sprintf "url(%s)", $new_url;

for consistency use 'url(' . $new_url . ')' here, or sprintf at line 577

@@ +692,5 @@
>              print "Creating $file...\n";
>              my $fh = IO::File->new( $file, O_WRONLY | O_CREAT, $info->{perms} )
>                  or die "unable to write $file: $!";
> +            my $contents = $info->{contents};
> +            if (ref $contents && ref($contents) eq 'CODE') {

ref() always returns a string; you don't need the first `ref $contents` check

@@ +697,5 @@
> +                print $fh $contents->();
> +            }
> +            else {
> +                print $fh $contents;
> +            }

writing $info->{contents} to $fh should only happen if $info->{contents} exists

Comment 5

[Dylan Hardison [:dylan] (he/him)]

To [e-mail]:mozilla-bteam/bmo.git
   38b13ae..3a372a9  master -> master