Closed Bug 1363824 Opened 6 years ago Closed 6 years ago

about:addons Experiments tab "Telemetry Preferences" link is broken

Categories

(Firefox :: Settings UI, defect, P1)

Product:
Firefox
Component:
Settings UI
Version:
55 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox56 --- fixed
firefox57 --- verified

People

(Reporter: nika, Assigned: rickychien)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [photon-preference])

Attachments

(2 files)

Screen Shot 2017-05-23 at 9.58.27 AM.png
157.82 KB, image/png
Details
Bug 1363824 - about:addons Experiments tab "Telemetry Preferences" link is broken
59 bytes, text/x-review-board-request
jaws
: review+
Details 
It links to about:preferences#advanced instead of about:preferences#privacy where telemetry settings are configured since the about:preferences redesign.
Here are some other links which are broken:

about:preferences#general > Performance > Learn more  (dead link)

about:preferences#privacy > Tracking Protection > Learn more  (note: link is not dead but has a note on it saying that the page is no longer maintained and is outdated - specifically "This article is no longer maintained, so its content might be out of date.")

about:preferences#privacy > Site Data -> Learn more  (dead link)

about:license contains a link to the about:buildconfig page, which doesn't work.

We should probably have some sort of check that all outbound links hardcoded into our product aren't 404ing.
Blocks: 1324168
Flags: needinfo?(jaws)
hi,

can you explain further where the link is? we do not understand where is about:add-on telemetry tab? which link is directly related to Preference?

thank you very much
Blocks: photon-preference
Flags: needinfo?(michael)
Priority: -- → P2
Whiteboard: [photon-preference]
It's in the "Experiments" tab - the "Telemetry Settings" link in the upper right hand corner of the attached screenshot.
Flags: needinfo?(michael)
I couldn't find the code implementing this panel in 3 min from searchfox.org, but I agree we should fix it.
Summary: about:addons Telemetry tab "Telemetry Preferences" link is broken → about:addons Experiments tab "Telemetry Preferences" link is broken
Version: unspecified → 55 Branch
Flags: needinfo?(jaws)
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #4)
> I couldn't find the code implementing this panel in 3 min from
> searchfox.org, but I agree we should fix it.

http://searchfox.org/mozilla-central/rev/2933592c4a01b634ab53315ce2d0e43fccb82181/toolkit/mozapps/extensions/content/extensions.js#1547-1554 is where the code is I believe.
Thanks for the pointer. This is a leftover from bug 1355522 and should be addressed accordingly.
Blocks: 1355522
Also, it's worthy to check comment 1 and see if there are more leftovers.
Priority: P2 → P3
This should be fixed in Fx56.
Priority: P3 → P2
Target Milestone: --- → Firefox 56
Michael,

can you tell us how to enable Experiments tab in Nightly's about:addons? 

I suspect that `extensions.ui.experiment.hidden` is the right flag to enable it but the value always be reset after reloading the about:addons page.
Flags: needinfo?(michael)
(In reply to Ricky Chien [:rickychien] from comment #9)
> Michael,
> 
> can you tell us how to enable Experiments tab in Nightly's about:addons? 
> 
> I suspect that `extensions.ui.experiment.hidden` is the right flag to enable
> it but the value always be reset after reloading the about:addons page.

I don't know what preference controls this, I just noticed that the link was wrong. On my nightly profile it is simply present. There is a chance that we hide it unless your profile has previously run a telemetry experiment, I'm not sure.

For me the "Experiments" entry appears at the bottom of the left column in about:addons on a mozilla-provided firefox build.
Flags: needinfo?(michael)
Following links are preferences relevant and has been fixed and verified.

* about:preferences#general > Performance > Learn more           --> Link fixed
* about:preferences#privacy > Tracking Protection > Learn more   --> Webpage has updated
* about:preferences#privacy > Site Data -> Learn more            --> Link fixed


Following link is preferences irrelevant, so it will not be fixed in this bug.

* about:license contains a link to the about:buildconfig page
I suspect this Telemetry feature is unable to be enabled on Nightly since always reset to hidden after toggling `extensions.ui.experiment.hidden` flag in about:config.

I can't figure out a normal and legal way to enable it, but we can force to be enabled by running

document.getElementById("category-experiment").hidden = false

in devtools's console. (Using normal Devtools can work, not browser toolbox needed)
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Flags: qe-verify+
Priority: P2 → P1
QA Contact: hani.yacoub
Jared, can you review this small patch for me? thanks!
Flags: needinfo?(jaws)
I am not sure if we'll need to uplift this patch to Fx55; please do if we need to.
Comment on attachment 8884780 [details]
Bug 1363824 - about:addons Experiments tab "Telemetry Preferences" link is broken

https://reviewboard.mozilla.org/r/155668/#review161442
Attachment #8884780 - Flags: review?(jaws) → review+
(In reply to Ricky Chien [:rickychien] from comment #14)
> Jared, can you review this small patch for me? thanks!

Please don't request needinfo if you've already requested review from me and there is nothing more to add. I'll see the review request in my queue as normal. Setting needinfo in addition just creates double work.
Flags: needinfo?(jaws)
I've verified that Fx55 doesn't have this issue. So let's land the patch. Thanks.
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d9bbed8efd0
about:addons Experiments tab "Telemetry Preferences" link is broken r=jaws
https://hg.mozilla.org/mozilla-central/rev/8d9bbed8efd0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Build ID: 20170808114032
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox57: --- → verified
You need to log in before you can comment on or make changes to this bug.