Implement new toolbar button hover and active background styles

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Theme
P1
normal
RESOLVED FIXED
12 days ago
5 days ago

People

(Reporter: nhnt11, Assigned: nhnt11)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 55
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [photon-visual][p1][57])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
Comment hidden (mozreview-request)
(Assignee)

Updated

12 days ago
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
(Assignee)

Updated

12 days ago
Blocks: 1363869

Updated

12 days ago
Iteration: --- → 55.5 - May 15
Flags: qe-verify?
Comment hidden (mozreview-request)
(Assignee)

Updated

12 days ago
Depends on: 1363840

Comment 3

11 days ago
mozreview-review
Comment on attachment 8866514 [details]
Bug 1363842 - Implement new toolbar button hover and active background styles.

https://reviewboard.mozilla.org/r/138138/#review141664

::: browser/themes/osx/browser.css:43
(Diff revision 2)
>    --toolbarbutton-hover-boxshadow: 0 1px 0 hsla(0,0%,100%,.5),
>                                     0 1px 0 hsla(0,0%,100%,.5) inset;
>  
> +%ifndef MOZ_PHOTON_THEME
>    --toolbarbutton-active-background: hsla(0,0%,0%,.02) linear-gradient(hsla(0,0%,0%,.12), transparent) border-box;
> +%endif

Please reorder the above lines such that you have this only once:

%ifdef MOZ_PHOTON_THEME
  ...
%else
  ...
%endif

::: browser/themes/osx/browser.css
(Diff revision 2)
> -  }
> -  #forward-button:-moz-window-inactive > .toolbarbutton-icon {
> -    box-shadow: 0 1px 0 0 rgba(0,0,0,0.2) inset,
> -                0 -1px 0 0 rgba(0,0,0,0.2) inset !important;
> -  }
> -}

We'll want to keep this in an %ifndef MOZ_PHOTON_THEME

::: browser/themes/shared/toolbarbuttons.inc.css:36
(Diff revision 2)
> +%endif
>    --toolbarbutton-hover-bordercolor: rgba(0,0,0,.2);
>  
> +%ifndef MOZ_PHOTON_THEME
>    --toolbarbutton-active-background: rgba(70%,70%,70%,.25);
> +%endif

See my comment on browser/themes/osx/browser.css

::: browser/themes/windows/browser.css:37
(Diff revision 2)
>    --toolbarbutton-hover-bordercolor: rgba(0,0,0,.2);
>    --toolbarbutton-hover-boxshadow: none;
>  
> +%ifndef MOZ_PHOTON_THEME
>    --toolbarbutton-active-background: rgba(0,0,0,.15);
> +%endif

ditto
Attachment #8866514 - Flags: review?(dao+bmo)
Comment hidden (mozreview-request)
(Assignee)

Updated

7 days ago
Blocks: 1365195

Comment 5

7 days ago
mozreview-review
Comment on attachment 8866514 [details]
Bug 1363842 - Implement new toolbar button hover and active background styles.

https://reviewboard.mozilla.org/r/138138/#review143012
Attachment #8866514 - Flags: review?(dao+bmo) → review+

Comment 6

7 days ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/374e39d64190
Implement new toolbar button hover and active background styles. r=dao
Iteration: 55.5 - May 15 → 55.6 - May 29
Flags: qe-verify? → qe-verify+
QA Contact: brindusa.tot

Comment 7

6 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/374e39d64190
Status: ASSIGNED → RESOLVED
Last Resolved: 6 days ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
(Assignee)

Updated

5 days ago
Blocks: 1365572
No longer blocks: 1365572
(Assignee)

Updated

5 days ago
Blocks: 1365901
You need to log in before you can comment on or make changes to this bug.