Detach the back and forward buttons from the location bar

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Theme
P1
normal
RESOLVED FIXED
14 days ago
2 days ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 55
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [photon-visual][p1])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

14 days ago
Summary: Visually detach the back button from the location bar → Detach the back and forward buttons from the location bar
Comment hidden (mozreview-request)
(Assignee)

Updated

14 days ago
Flags: qe-verify+
Priority: -- → P1

Updated

14 days ago
Iteration: --- → 55.5 - May 15
QA Contact: brindusa.tot
Blocks: 1363869
Blocks: 1363842

Comment 2

14 days ago
mozreview-review
Comment on attachment 8866475 [details]
Bug 1363840 - Detach the back and forward buttons from the location bar.

https://reviewboard.mozilla.org/r/138104/#review141320

At least in OSX we can make the forward button look a bit nicer by disabling shorlander's recent changes: https://searchfox.org/mozilla-central/rev/d66b9f27d5630a90b2fce4d70d4e9050f43df9b4/browser/themes/osx/browser.css#579

And in compact theme we should disable the forward button and urlbar borders:
https://searchfox.org/mozilla-central/source/browser/themes/shared/compacttheme.inc.css#209
https://searchfox.org/mozilla-central/source/browser/themes/shared/compacttheme.inc.css#262
Attachment #8866475 - Flags: review?(jhofmann)
Comment hidden (mozreview-request)
(Assignee)

Comment 4

14 days ago
Compact themes still don't seem perfect with MOZ_PHOTON_THEME, but I don't think we need to spend more time on this now since this stuff will change drastically anyway.

Comment 5

14 days ago
mozreview-review
Comment on attachment 8866475 [details]
Bug 1363840 - Detach the back and forward buttons from the location bar.

https://reviewboard.mozilla.org/r/138104/#review141334

I agree, those were just the most visible things. Want to avoid followup discussions :)
Attachment #8866475 - Flags: review?(jhofmann) → review+

Comment 6

14 days ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a46c4ea1cf30
Detach the back and forward buttons from the location bar. r=johannh

Comment 7

14 days ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/83478ac51418
followup: fix browser_formless_submit_chrome.js on CLOSED TREE
https://hg.mozilla.org/mozilla-central/rev/a46c4ea1cf30
https://hg.mozilla.org/mozilla-central/rev/83478ac51418
Status: ASSIGNED → RESOLVED
Last Resolved: 14 days ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Updated

13 days ago
Depends on: 1364477

Comment 9

12 days ago
Hi ,
cannot change the position of back/forward button.
After this bug landed it should have been possible right?
(Assignee)

Comment 10

12 days ago
(In reply to jaruvova from comment #9)
> Hi ,
> cannot change the position of back/forward button.
> After this bug landed it should have been possible right?

This was the first step. Bug 1363485 will open up the possibility to move these elements, at least indirectly by moving other elements between these ones.
(Assignee)

Updated

12 days ago
No longer depends on: 1364477

Comment 11

12 days ago
(In reply to Dão Gottwald [::dao] from comment #10)
> (In reply to jaruvova from comment #9)
> > Hi ,
> > cannot change the position of back/forward button.
> > After this bug landed it should have been possible right?
> 
> This was the first step. Bug 1363485 will open up the possibility to move
> these elements, at least indirectly by moving other elements between these
> ones.

oh okay thanks

Updated

11 days ago
Depends on: 1364702

Comment 12

11 days ago
I can see this implemented in Latest Nightly 55.0a1 on Manjaro Linux 17, 64bit

Build ID 	20170513100302
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

[testday-20170513]
Mozscreenshots results:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=838652a84b76c273e084d0705f3f4f3be89520a8&newProject=mozilla-central&newRev=0259418f19ab804b126730ef1d5d03006d6aad52

Looks all good to me.
You need to log in before you can comment on or make changes to this bug.