Closed Bug 1364178 Opened 8 years ago Closed 8 years ago

this._urlListener is undefined - on box.com filelink auth failure.

Categories

(Thunderbird :: FileLink, defect)

Product:
Thunderbird
Component:
FileLink
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr5254+ fixed, thunderbird54 fixed, thunderbird55 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 55.0
Tracking Flags:
Tracking Status
thunderbird_esr52 54+ fixed
thunderbird54 --- fixed
thunderbird55 --- fixed

People

(Reporter: mkmelin, Assigned: mkmelin)

Details

Attachments

(1 file)

bugXXX_filelink_urlListener.patch
2.42 KB, patch
clokep
: review+
jorgk-bmo
: approval-comm-beta+
jorgk-bmo
: approval-comm-esr52+
Details | Diff | Splinter Review
Got a failure for a box.com filelink upload. this._urlListener is undefined Apparently copy pasted code from nsHightail.js, but forgot to assign the _urlListener. Let's not use those assignments (as the variable isn't used elsewhere).
Attachment #8866901 - Flags: review?(clokep)
Comment on attachment 8866901 [details] [diff] [review] bugXXX_filelink_urlListener.patch Review of attachment 8866901 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. Nice find!
Attachment #8866901 - Flags: review?(clokep) → review+
Ready to land?
Flags: needinfo?(mkmelin+mozilla)
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/b7c66885ee8ba0ebeea9a2a241593bf9b28c3af7 Uplift?
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
Comment on attachment 8866901 [details] [diff] [review] bugXXX_filelink_urlListener.patch Review of attachment 8866901 [details] [diff] [review]: ----------------------------------------------------------------- Yes this should be uplifted
Attachment #8866901 - Flags: approval-comm-esr52?
Attachment #8866901 - Flags: approval-comm-beta?
Comment on attachment 8866901 [details] [diff] [review] bugXXX_filelink_urlListener.patch Thanks.
Attachment #8866901 - Flags: approval-comm-beta? → approval-comm-beta+
Flags: needinfo?(mkmelin+mozilla)
Attachment #8866901 - Flags: approval-comm-esr52? → approval-comm-esr52+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: