Gamepad on Android is broken

RESOLVED FIXED in Firefox 55

Status

()

Firefox for Android
General
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: rbarker, Assigned: rbarker)

Tracking

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
Gamepad on Android asserts in debug builds.

Additionally, axis values are getting dropped when more than one axis is non-zero.

STR:

1) Press a stick to the far right.
2) With out moving from the right, move the stick slightly up or down so the horizontal axis value doesn't change but the virtical axis will emit a value.

Expected result:
Both axes will generate a value.

Actually result:
The horizontal axis will got to zero.
(Assignee)

Updated

7 months ago
Assignee: nobody → rbarker
Comment hidden (mozreview-request)

Comment 2

7 months ago
mozreview-review
Comment on attachment 8867010 [details]
Bug 1364267 - Prevent Android gamepad from dropping axis values

https://reviewboard.mozilla.org/r/138614/#review142112

Any idea what broke this?
Attachment #8867010 - Flags: review?(ted) → review+
(Assignee)

Comment 3

7 months ago
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
>
> Any idea what broke this?

Looks like Bug 1289208. Also, it looks like my fix isn't actually correct looking at how it used to work. I'll post an update.
Comment hidden (mozreview-request)

Comment 5

7 months ago
Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/854dc4d83215
Prevent Android gamepad from dropping axis values r=ted
https://hg.mozilla.org/mozilla-central/rev/854dc4d83215
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.