1364267 - Gamepad on Android is broken

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Randall Barker [:rbarker]]

Gamepad on Android asserts in debug builds.

Additionally, axis values are getting dropped when more than one axis is non-zero.

STR:

1) Press a stick to the far right.
2) With out moving from the right, move the stick slightly up or down so the horizontal axis value doesn't change but the virtical axis will emit a value.

Expected result:
Both axes will generate a value.

Actually result:
The horizontal axis will got to zero.

Comment 1

[Randall Barker [:rbarker]]

Attachment: Bug 1364267 - Prevent Android gamepad from dropping axis values

Review commit: https://reviewboard.mozilla.org/r/138614/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138614/

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8867010 [details]
Bug 1364267 - Prevent Android gamepad from dropping axis values

https://reviewboard.mozilla.org/r/138614/#review142112

Any idea what broke this?

Comment 3

[Randall Barker [:rbarker]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
>
> Any idea what broke this?

Looks like Bug 1289208. Also, it looks like my fix isn't actually correct looking at how it used to work. I'll post an update.

Comment 4

[Randall Barker [:rbarker]]

Comment on attachment 8867010 [details]
Bug 1364267 - Prevent Android gamepad from dropping axis values

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138614/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/854dc4d83215
Prevent Android gamepad from dropping axis values r=ted

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/854dc4d83215