Closed Bug 1364289 Opened 6 years ago Closed 5 years ago

stylo: Decide what to do with -moz-use-system-font

Categories

(Core :: CSS Parsing and Computation, enhancement, P2)

53 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file, 1 obsolete file)

There are several tests relying on -moz-use-system-font value be serialized for font subproperties when system font is set on font shorthand, at least
* test_system_font_serialization.html
* test_value_storage.html

It seems to me changing test_system_font_serialization.html is probably not a big deal, but test_value_storage.html is checking that setting font shorthand actually sets the subproperties to something, which is probably harder to workaround.

I'm not sure what should we do here. Probably we should just make Stylo serialize subproperties to -moz-use-system-font in that case like Gecko, so that we don't need to think a lot about how should we workaround the tests.
Manish, what do you think about this?
Flags: needinfo?(manishearth)
I guess we could serialize to system font.
Flags: needinfo?(manishearth)
Assignee: nobody → nox
Status: NEW → ASSIGNED
Priority: -- → P2
I guess nox doesn't like working on this kind of bugs. Stealing.

We can probably just do what Gecko does at the moment. I don't think it matters a lot.

A perfect solution would probably be that, when someone tries to serialize the longhand but we have a system font, we compute the system font and uncompute the corresponding longhand value, so that we get the effective value there. It is unknown what this means for webcompat, though, so I'm not going to risk it for now.
Assignee: nox → xidorn+moz
Hmmm... Also filed w3c/csswg-drafts#1586 for this.
Comment on attachment 8885089 [details]
Serialize font longhands to -moz-use-system-font when using system font like what Gecko does.

https://reviewboard.mozilla.org/r/155936/#review161094
Attachment #8885089 - Flags: review?(manishearth) → review+
Comment on attachment 8885090 [details]
Bug 1364289 - Update mochitest expectation.

https://reviewboard.mozilla.org/r/155938/#review161096
Attachment #8885090 - Flags: review?(manishearth) → review+
Attachment #8885089 - Attachment is obsolete: true
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d606c0776761
Update mochitest expectation. r=manishearth
https://hg.mozilla.org/mozilla-central/rev/d606c0776761
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.