1364289 - stylo: Decide what to do with -moz-use-system-font

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Xidorn Quan [:xidorn] UTC+10]

There are several tests relying on -moz-use-system-font value be serialized for font subproperties when system font is set on font shorthand, at least
* test_system_font_serialization.html
* test_value_storage.html

It seems to me changing test_system_font_serialization.html is probably not a big deal, but test_value_storage.html is checking that setting font shorthand actually sets the subproperties to something, which is probably harder to workaround.

I'm not sure what should we do here. Probably we should just make Stylo serialize subproperties to -moz-use-system-font in that case like Gecko, so that we don't need to think a lot about how should we workaround the tests.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Manish, what do you think about this?

Comment 2

[Manish Goregaokar [:manishearth]]

I guess we could serialize to system font.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

I guess nox doesn't like working on this kind of bugs. Stealing.

We can probably just do what Gecko does at the moment. I don't think it matters a lot.

A perfect solution would probably be that, when someone tries to serialize the longhand but we have a system font, we compute the system font and uncompute the corresponding longhand value, so that we get the effective value there. It is unknown what this means for webcompat, though, so I'm not going to risk it for now.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Also filed w3c/csswg-drafts/1586 for this.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

w3c/csswg-drafts#1586

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Hmmm... Also filed w3c/csswg-drafts#1586 for this.

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Serialize font longhands to -moz-use-system-font when using system font like what Gecko does.

Review commit: https://reviewboard.mozilla.org/r/155936/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155936/

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1364289 - Update mochitest expectation.

Review commit: https://reviewboard.mozilla.org/r/155938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155938/

Comment 9

[Manish Goregaokar [:manishearth]]

Comment on attachment 8885089 [details]
Serialize font longhands to -moz-use-system-font when using system font like what Gecko does.

https://reviewboard.mozilla.org/r/155936/#review161094

Comment 10

[Manish Goregaokar [:manishearth]]

Comment on attachment 8885090 [details]
Bug 1364289 - Update mochitest expectation.

https://reviewboard.mozilla.org/r/155938/#review161096

Comment 11

[Xidorn Quan [:xidorn] UTC+10]

Servo PR: servo/servo#17660

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d606c0776761
Update mochitest expectation. r=manishearth

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d606c0776761