1364505 - Don't offer to load Flash (when Ask-to-Activate) if it has no srcURI

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

+++ This bug was initially created as a clone of Bug #1363713 +++

Copying Description & User Story from bug 1363713. That bug handled this in the shield addon, and this bug is to handle this in the favor fallback code.

========

The SWFObject library is used extensively throughout the web as a wrapper for instantiating Flash on various browsers. It has a function that it runs at startup `testPlayerVersion` which checks the Flash version by creating an "empty" Flash instance (no data).

https://github.com/swfobject/swfobject/blob/master/swfobject/src/swfobject.js#L188

This triggers the plugin infobar in every case and seems to be one of the most common reasons for seeing the infobar.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1364505 - Add a rule to favor plugin fallback content when no srcURI has been specified.

Review commit: https://reviewboard.mozilla.org/r/139390/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139390/

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1364505 - Write tests for plugin favor-fallback mode.

Review commit: https://reviewboard.mozilla.org/r/139392/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139392/

Comment 3

[:Felipe Gomes (needinfo for replies!)]

So the patch for this turned out to be really simple! I realized I forgot to write tests for this feature, so I write a comprehensive one that covers this new rule and all the past rules.

I intend to activate this rule + the "video" rule in bug 1317856 (for Nightly users)

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8867851 [details]
Bug 1364505 - Add a rule to favor plugin fallback content when no srcURI has been specified.

https://reviewboard.mozilla.org/r/139390/#review143178

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8867852 [details]
Bug 1364505 - Write tests for plugin favor-fallback mode.

https://reviewboard.mozilla.org/r/139392/#review143180

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Didn't see a patch over there for it yet (guessing you were waiting for me here, since you mentioned in Comment #3), but just making sure, you're adding the nosrc rule in another patch on bug 1317856 then, right?

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Yep, that is correct!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f35b966ff024
Add a rule to favor plugin fallback content when no srcURI has been specified. r=qDot
https://hg.mozilla.org/integration/mozilla-inbound/rev/e30e7ee30b7c
Write tests for plugin favor-fallback mode. r=qDot

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f35b966ff024
https://hg.mozilla.org/mozilla-central/rev/e30e7ee30b7c