1364591 - stylo: implement :-moz-native-anonymous support

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

Patches coming up once I sort through the try fail.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix style sharing cache lookups to compare ids of the two elements.

Otherwise we can have a situation like this:

  <style>
    .notmatching > #foo {}
  </style>
  <span id="foo"></span>
  <span></span>

and the style sharing cache lookup for the second <span> would try to revalidate
against the cached value for the first <span>, but end up failing asserts about
the two elements matching lists of revalidation selectors that have the same
length.

Review commit: https://reviewboard.mozilla.org/r/139374/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139374/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1364591 test expectation update, now that we implement :-moz-native-anonymous support in stylo.

Review commit: https://reviewboard.mozilla.org/r/139376/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139376/

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8867841 [details]
Fix style sharing cache lookups to compare ids of the two elements.

https://reviewboard.mozilla.org/r/139374/#review142704

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8867842 [details]
Bug 1364591 test expectation update, now that we implement :-moz-native-anonymous support in stylo.

https://reviewboard.mozilla.org/r/139376/#review142708

::: servo/components/style/gecko/non_ts_pseudo_class_list.rs:29
(Diff revision 1)
>   *
>   * Pending pseudo-classes:
>   *
>   *  :-moz-is-html -> Used only in UA sheets, should be easy to support.
> - *  :-moz-native-anonymous -> For devtools, seems easy-ish?
>   *  :-moz-bound-element -> Seems unused, should be easy to remove.

Feel free to remove the :-moz-bound-element line too while you're around if you want to.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8867842 [details]
Bug 1364591 test expectation update, now that we implement :-moz-native-anonymous support in stylo.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/139376/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea03ef9a0a42
test expectation update, now that we implement :-moz-native-anonymous support in stylo.  r=emilio

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ea03ef9a0a42