Enable asserts in moz.build for ANGLE

RESOLVED FIXED in Firefox 55

Status

()

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: svargas, Assigned: svargas, Mentored)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: gfx-noted)

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
Comment on attachment 8867393 [details] [diff] [review]
0001-Bug-1364592-Enable-asserts-in-moz.build-for-ANGLE-r-.patch

Review of attachment 8867393 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/angle/moz.build
@@ +147,5 @@
>      DEFINES['_SECURE_SCL'] = 0
>  
>  DEFINES['ANGLE_ENABLE_D3D9'] = True
> +
> +DEFINES['ANGLE_ASSERTS_ON'] = True

This unconditionally enables asserts, and will probably cause a build to fail because of macro redefinition.
Remove this line.

@@ +148,5 @@
>  
>  DEFINES['ANGLE_ENABLE_D3D9'] = True
> +
> +DEFINES['ANGLE_ASSERTS_ON'] = True
> +DEFINES['NOASSERT_UNIMPLEMENTED'] = False

Leave a comment:
# Enable asserts for UNIMPLEMENTED().
Attachment #8867393 - Flags: review?(jgilbert) → review-
(Assignee)

Updated

2 years ago
Assignee: nobody → svargas
(Assignee)

Comment 3

2 years ago
Attachment #8867393 - Attachment is obsolete: true
Attachment #8867401 - Flags: review?(jgilbert)
Attachment #8867401 - Flags: review?(jgilbert) → review+
(Assignee)

Comment 4

2 years ago
The previous patch file didn't actually override the #define NOASSERT_UNIMPLEMENTED in angle/src/debug.h. This patch updates all four
moz.builds with the correct value for NOASSERT_UNIMPLEMENTED.

This patch is related to: https://bugzilla.mozilla.org/show_bug.cgi?id=1364169#c8
This patch should cause the if (mRobustAccess) { UNIMPLEMENTED(); } to trigger an assert preventing the aforementioned bug from occurring. (The next step would be to disable robust access if on ANGLE to prevent this assert from occurring).
Attachment #8867401 - Attachment is obsolete: true
Attachment #8867890 - Flags: review?(jgilbert)
Attachment #8867890 - Flags: review?(jgilbert) → review+

Comment 5

2 years ago
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c57d9481b54
Enable asserts in moz.build for ANGLE - r=jgilbert
Blocks: 1365067
Priority: -- → P1
Whiteboard: gfx-noted

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7c57d9481b54
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.