1364592 - Enable asserts in moz.build for ANGLE

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement, P1)

Comment 1

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1364592-Enable-asserts-in-moz.build-for-ANGLE-r-.patch

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8867393 [details] [diff] [review]
0001-Bug-1364592-Enable-asserts-in-moz.build-for-ANGLE-r-.patch

Review of attachment 8867393 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/angle/moz.build
@@ +147,5 @@
>      DEFINES['_SECURE_SCL'] = 0
>  
>  DEFINES['ANGLE_ENABLE_D3D9'] = True
> +
> +DEFINES['ANGLE_ASSERTS_ON'] = True

This unconditionally enables asserts, and will probably cause a build to fail because of macro redefinition.
Remove this line.

@@ +148,5 @@
>  
>  DEFINES['ANGLE_ENABLE_D3D9'] = True
> +
> +DEFINES['ANGLE_ASSERTS_ON'] = True
> +DEFINES['NOASSERT_UNIMPLEMENTED'] = False

Leave a comment:
# Enable asserts for UNIMPLEMENTED().

Comment 3

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1364592-Enable-asserts-in-moz.build-for-ANGLE-r-.patch

Comment 4

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1364592-Enable-asserts-in-moz.build-for-ANGLE-r-.patch

The previous patch file didn't actually override the #define NOASSERT_UNIMPLEMENTED in angle/src/debug.h. This patch updates all four
moz.builds with the correct value for NOASSERT_UNIMPLEMENTED.

This patch is related to: https://bugzilla.mozilla.org/show_bug.cgi?id=1364169#c8
This patch should cause the if (mRobustAccess) { UNIMPLEMENTED(); } to trigger an assert preventing the aforementioned bug from occurring. (The next step would be to disable robust access if on ANGLE to prevent this assert from occurring).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c57d9481b54
Enable asserts in moz.build for ANGLE - r=jgilbert

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7c57d9481b54