Closed Bug 1365067 Opened 3 years ago Closed 3 years ago

RBAB is requested on ANGLE but is not implemented

Categories

(Core :: Canvas: WebGL, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: svargas, Assigned: svargas)

References

Details

(Whiteboard: gfx-noted)

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → svargas
Comment on attachment 8867905 [details] [diff] [review]
0001-Bug-1365067-rbab-is-requested-on-ANGLE-but-is-not-im.patch

Review of attachment 8867905 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextProviderEGL.cpp
@@ +497,5 @@
>              // Skip EGL_CONTEXT_OPENGL_ROBUST_ACCESS_EXT, since it doesn't help us.
>          }
>  
> +        if (sEGLLibrary.IsExtensionSupported(GLLibraryEGL::KHR_create_context) &&
> +            !sEGLLibrary.IsANGLE()) {

{ its own line, since this is a multi-line conditional now.
Attachment #8867905 - Flags: review?(jgilbert) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/70768edfd562
rbab is requested on ANGLE but is not implemented - r=jgilbert
Same on Win8.
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7476402eadc3
rbab is requested on ANGLE but is not implemented - r=jgilbert
Depends on: 1364592
Priority: -- → P1
Summary: rbab is requested on ANGLE but is not implemented → RBAB is requested on ANGLE but is not implemented
Whiteboard: gfx-noted
Blocks: 1364169
https://hg.mozilla.org/mozilla-central/rev/7476402eadc3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.