RBAB is requested on ANGLE but is not implemented

RESOLVED FIXED in Firefox 55

Status

()

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: svargas, Assigned: svargas)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: gfx-noted)

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Assignee: nobody → svargas
Comment on attachment 8867905 [details] [diff] [review]
0001-Bug-1365067-rbab-is-requested-on-ANGLE-but-is-not-im.patch

Review of attachment 8867905 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextProviderEGL.cpp
@@ +497,5 @@
>              // Skip EGL_CONTEXT_OPENGL_ROBUST_ACCESS_EXT, since it doesn't help us.
>          }
>  
> +        if (sEGLLibrary.IsExtensionSupported(GLLibraryEGL::KHR_create_context) &&
> +            !sEGLLibrary.IsANGLE()) {

{ its own line, since this is a multi-line conditional now.
Attachment #8867905 - Flags: review?(jgilbert) → review+

Comment 4

2 years ago
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/70768edfd562
rbab is requested on ANGLE but is not implemented - r=jgilbert
Same on Win8.

Comment 7

2 years ago
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7476402eadc3
rbab is requested on ANGLE but is not implemented - r=jgilbert
Depends on: 1364592
Priority: -- → P1
Summary: rbab is requested on ANGLE but is not implemented → RBAB is requested on ANGLE but is not implemented
Whiteboard: gfx-noted
Blocks: 1364169

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7476402eadc3
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.