1365067 - RBAB is requested on ANGLE but is not implemented

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Comment 1

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1365067-rbab-is-requested-on-ANGLE-but-is-not-im.patch

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8867905 [details] [diff] [review]
0001-Bug-1365067-rbab-is-requested-on-ANGLE-but-is-not-im.patch

Review of attachment 8867905 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextProviderEGL.cpp
@@ +497,5 @@
>              // Skip EGL_CONTEXT_OPENGL_ROBUST_ACCESS_EXT, since it doesn't help us.
>          }
>  
> +        if (sEGLLibrary.IsExtensionSupported(GLLibraryEGL::KHR_create_context) &&
> +            !sEGLLibrary.IsANGLE()) {

{ its own line, since this is a multi-line conditional now.

Comment 3

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1365067-rbab-is-requested-on-ANGLE-but-is-not-im.patch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/70768edfd562
rbab is requested on ANGLE but is not implemented - r=jgilbert

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Backed for various Win7 mochitest-gl failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/daf0c22a7f03582e9a47928fd46f058f59d66b99

https://treeherder.mozilla.org/logviewer.html#?job_id=101775984&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=101775669&repo=mozilla-inbound

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Same on Win8.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7476402eadc3
rbab is requested on ANGLE but is not implemented - r=jgilbert

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7476402eadc3