1364702 - Forward button looks like Back button in RTL locales

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Itiel]

Attachment: Forward button reversed.png

See attached.
The left button (Forward in RTL locales) should point left. The right button (Back) is okay.

This is a regression of bug 1363840 according to Mozregression.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1364702 - [RTL] mirror the back button in toolbarbutton-icons.inc.css like other buttons, and also mirror the forward button for Photon (non-Photon forward button is handled in browser.css).

Review commit: https://reviewboard.mozilla.org/r/139038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139038/

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8867496 [details]
Bug 1364702 - [RTL] mirror the back button in toolbarbutton-icons.inc.css like other buttons, and also mirror the forward button for Photon (non-Photon forward button is handled in browser.css).

https://reviewboard.mozilla.org/r/139038/#review142444

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c10971e1e4f3
[RTL] mirror the back button in toolbarbutton-icons.inc.css like other buttons, and also mirror the forward button for Photon (non-Photon forward button is handled in browser.css). r=johannh

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c10971e1e4f3

Comment 5

[Carmen Fat [:cfat] - Ecosystem QA]

I managed to reproduce the issue on an older Nightly 55.0a1 RTL build (2017-05-12) using Windows 10 x64.

The issue doesn't reproduce anymore on the latest Nightly 55.0a1 RTL build (2017-05-16) across platforms: Windows 10 x64, Ubuntu 16.04 LTS x64 and Mac OS X 10.12.5.