Closed Bug 1364746 Opened 6 years ago Closed 6 years ago

stylo: Continue to propagate quirks mode information to Servo

Categories

(Core :: CSS Parsing and Computation, enhancement, P1)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: canova, Assigned: canova)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1364746 - stylo: Continue to propagate quirks mode information to Servo
59 bytes, text/x-review-board-request
bholley
: review+
Details
Bug 1364746 - stylo: Update test expectations for unitless length quirk
59 bytes, text/x-review-board-request
bholley
: review+
Details 
I've propagated quirks mode information on some places in Bug 1360488. It was a start but it isn't enough for all quirks mode. Also it didn't make all tests pass. I'll continue to work on this in this bug.
Comment on attachment 8867542 [details]
Bug 1364746 - stylo: Continue to propagate quirks mode information to Servo

https://reviewboard.mozilla.org/r/139090/#review142318

There ere still some static `NoQuirks` in glue.rs file. But I don't think we need to pass real quirks mode information to them.

::: servo/ports/geckolib/glue.rs:1856
(Diff revision 1)
>  #[no_mangle]
> -pub extern "C" fn Servo_CSSSupports2(property: *const nsACString, value: *const nsACString) -> bool {
> +pub extern "C" fn Servo_CSSSupports2(property: *const nsACString,
> +                                     value: *const nsACString) -> bool {
>      let id = get_property_id_from_property!(property, false);
>  
> -    parse_property(id, value, unsafe { DUMMY_URL_DATA }, structs::LengthParsingMode::Default).is_ok()
> +    // FIXME: Other parameters are dummy. I guess it's ok to pass NoQuirks here.

In here, other parameters are dummy so I passed just NoQuirks here. Do we need to get actual quirk info for that function?
Comment on attachment 8867542 [details]
Bug 1364746 - stylo: Continue to propagate quirks mode information to Servo

https://reviewboard.mozilla.org/r/139092/#review142346
Attachment #8867542 - Flags: review?(bobbyholley) → review+
Comment on attachment 8867907 [details]
Bug 1364746 - stylo: Update test expectations for unitless length quirk

https://reviewboard.mozilla.org/r/139438/#review142988
Attachment #8867907 - Flags: review?(bobbyholley) → review+
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/dad46e25b2d7
stylo: Continue to propagate quirks mode information to Servo r=bholley
https://hg.mozilla.org/integration/autoland/rev/3dda5445e08d
stylo: Update test expectations for unitless length quirk r=bholley
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2a534e65b84f
More reftest expectation updates. r=me
Hmm, so I was updating the test expectations without noticing the gecko side of your patch hadn't landed yet.

Nazim, if those tests I updated happen to not pass, could you please file a bug to investigate those? They're definitely related to parsing without units, so if they're not passing there's a bug servo-side.
Sure, I'll look into it.
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0be21772f2f9
Revert "Bug 1364746: More reftest expectation updates. r=me"
Priority: -- → P1
I think this has been fixed.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.