136475 - Search UI: File/Del/Open buttons don't enable properly on 2nd search (BRANCH)

Status: VERIFIED DUPLICATE of bug 134893

(SeaMonkey :: MailNews: Message Display, defect)

Description

[laurel]

Using appr9 commercial trunk build

If you select a search result in advanced search, select a result then do
another search which yields matches, when you select a search result in the
second search none of the operational buttons (Open,File,Delete,Open Message
Folder) enable.

Steps:

1.  From mail window, Tools|Search Messages.
2.  Choose a mail or news account, initiate a search which will yield matches.
3.  Select a search result...note the Open/File/Delete/OpenFolder buttons enable. 
4.  Clear (or don't clear -- doesn't make a difference) the search, initiate
another search which will yield results.
5.  Select a search result ... none of the operations buttons enable.  Note that
when you do a multiple selection, the buttons indeed will enable and will stay
enabled if you go to single selection. If another search is done, you're in the
same boat again.

Result:  after first search in the Advance Search dialog session, buttons do not
enable properly upon a single result selection.

Expected:  buttons enable properly in every search.

Comment 1

[laurel]

regression, this worked in early march builds

Comment 2

[Navin Gupta]

wfm in today's mozilla debug build. 

Comment 3

[Navin Gupta]

worksforme in today's trunk builds.

Comment 4

[laurel]

Not working in today's branch build: win98, linux rh6.2
Is working in the trunk build (tried on linux)

Comment 5

[laurel]

Talked to Scott P. and decided to reopen this for tracking for RTM.

Comment 6

[scottputterman]

Let's try to get this in for rtm.

Comment 7

[Navin Gupta]

Attachment: proposed fix

This fix is intended for branch but it can be checked on trunk also. On trunk
FireOnSelectHandler is getting called when row count changes from oldSize to 0.

Comment 8

[Navin Gupta]

david, can you review ? thx. FireOnSelectHandler calls our SelectionChanged(). 

Comment 9

[David :Bienvenu]

if this works on the trunk, then it's probably because of the fix I made for the
general selection problem, and it would be better to check that fix in instead.
Does this currently work on the trunk without your change, Navin?

Comment 10

[David :Bienvenu]

In particular, I'm thinking of the fix in bug 134893 - one of these patches
should be checked into the branch, not individual little tweaks to fix all the
bugs that bug 134893 (assuming this is one of those bugs)

Comment 11

[David :Bienvenu]

excuse me, I meant one of "those" fixes, the ones in  bug 134893

Comment 12

[Navin Gupta]

bug 134893 doesn't fix this, I applied your patch on branch and it doesn't
fix it. 

Comment 13

[Navin Gupta]

yes, this is currently working on trunk. 

Comment 14

[David :Bienvenu]

why does it work on the trunk? I guess I'll have to try the patch on the branch
as well...

Comment 15

[David :Bienvenu]

my fix in bug 134893 DOES fix this problem. I applied
http://bugzilla.mozilla.org/attachment.cgi?id=79536&action=view (the next to
last patch in the bug), rebuilt chrome from the mailnews directory, and tried
this scenario. It worked fine. It didn't work before applying the patch.

Comment 16

[Navin Gupta]

I don't know how it is working for me today with your patch! I did have your 
patch in my branch yesterday. That was the first thing I tried. 

marking dependency on bug 134893

Comment 17

[David :Bienvenu]

did you rebuild the mailnews chrome yesterday? Anyway, my fix should be
fine...so this can be a dup of the other bug, actually.

Comment 18

[Navin Gupta]

I did build my mailnews chrome directory yesterday. I'm sure because I checked 
in bug 139833 which has .xul and .js file.

Anyway marking dup


*** This bug has been marked as a duplicate of 134893 ***

Comment 19

[laurel]

*** Bug 143270 has been marked as a duplicate of this bug. ***

Comment 20

[laurel]

*** Bug 147965 has been marked as a duplicate of this bug. ***

Comment 21

[laurel]

Marking verified as a duplicate and also it is working in may31 branch build -
fixed in bug 134893