Data channel fails to open if maxPacketLifeTime is set

RESOLVED FIXED in Firefox 55

Status

()

Core
WebRTC: Networking
P2
normal
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: drno, Assigned: drno)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: regression)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

11 months ago
If maxPacketLifeTime is set to a non zero value in the DataChannel dict the data channel fails to open as reported here: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/discuss-webrtc/PPY8164HLus/NIpU0xPSAQAJ

A run with logs shows this:

2017-05-15 22:46:33.986490 UTC - [Socket Thread]: D/DataChannel Association change: SCTP_COMM_UP
2017-05-15 22:46:33.986492 UTC - [Socket Thread]: D/DataChannel DTLS connect() succeeded!  Entering connected mode
2017-05-15 22:46:33.986494 UTC - [Socket Thread]: D/DataChannel Processing queued open for 0x11e765f00 (65535)
2017-05-15 22:46:33.986496 UTC - [Socket Thread]: D/DataChannel SendOpenRequest failed, errno = 0
2017-05-15 22:46:33.986497 UTC - [Socket Thread]: D/DataChannel Association change: streams (in/out) = (256/256)
2017-05-15 22:46:33.986498 UTC - [Socket Thread]: D/DataChannel Supports: PR
2017-05-15 22:46:33.986499 UTC - [Socket Thread]: D/DataChannel Supports: AUTH
2017-05-15 22:46:33.986500 UTC - [Socket Thread]: D/DataChannel Supports: ASCONF
2017-05-15 22:46:33.986501 UTC - [Socket Thread]: D/DataChannel Supports: MULTIBUF
2017-05-15 22:46:33.986502 UTC - [Socket Thread]: D/DataChannel Supports: RE-CONFIG

Which points to here: http://searchfox.org/mozilla-central/rev/ae24a3c83d22e0e35aecfd9049c2b463ca7e045b/netwerk/sctp/datachannel/DataChannel.cpp#2113
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 4

11 months ago
Looks like the change in the webidl in bug 1319542 changed the numbers in |type|, which then revealed this long standing bug.
Assignee: nobody → drno
Depends on: 1319542
Whiteboard: regression

Comment 5

11 months ago
mozreview-review
Comment on attachment 8867974 [details]
Bug 1365081: really use prPolicy as the pocily input value.

https://reviewboard.mozilla.org/r/139510/#review142894
Attachment #8867974 - Flags: review?(rjesup) → review+

Comment 6

11 months ago
mozreview-review
Comment on attachment 8867975 [details]
Bug 1365081: added data channel test function for maxPacketLifeTime.

https://reviewboard.mozilla.org/r/139512/#review142896
Attachment #8867975 - Flags: review?(rjesup) → review+

Comment 7

11 months ago
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/0bc24db05046
really use prPolicy as the pocily input value. r=jesup
https://hg.mozilla.org/integration/autoland/rev/d559a766a802
added data channel test function for maxPacketLifeTime. r=jesup

Comment 8

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0bc24db05046
https://hg.mozilla.org/mozilla-central/rev/d559a766a802
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Hello, :drno. Did this change affected any kind of browser startup functionality? If you look over this graph, there is an extra regression after the previous ones:

https://treeherder.mozilla.org/perf.html#/graphs?series=%5Bmozilla-inbound,c22155824871783bb5d8f514b3a01b4c885034c0,0,1%5D&series=%5Bautoland,c22155824871783bb5d8f514b3a01b4c885034c0,1,1%5D&highlightedRevisions=d559a766a802&highlightAlerts=0&zoom=1495031165361.8843,1495097946000,800,1347.8260869565217

An answer would help my investigation.
Flags: needinfo?(drno)
(Assignee)

Comment 10

11 months ago
(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #9)
> Hello, :drno. Did this change affected any kind of browser startup
> functionality? If you look over this graph, there is an extra regression
> after the previous ones:
> 
> https://treeherder.mozilla.org/perf.html#/graphs?series=%5Bmozilla-inbound,
> c22155824871783bb5d8f514b3a01b4c885034c0,0,1%5D&series=%5Bautoland,
> c22155824871783bb5d8f514b3a01b4c885034c0,1,
> 1%5D&highlightedRevisions=d559a766a802&highlightAlerts=0&zoom=1495031165361.
> 8843,1495097946000,800,1347.8260869565217
> 
> An answer would help my investigation.

No the change should only affect any tests in dom/media/tests/mochitest/test_dataChannel*. These tests should be running in the mda2 block. It might also affect some web platform tests. But nothing regarding startup or session restore.
Flags: needinfo?(drno)
You need to log in before you can comment on or make changes to this bug.