1319542 - Update pc.createDataChannel's RTCDataChannelInit dict to spec.

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

While cleaning up PeerConnection.js I'm finding various areas of neglect. createDataChannel is one.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1319542 - Update RTCDataChannelInit to spec, and remove support for old deprecated values.

Review commit: https://reviewboard.mozilla.org/r/94818/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94818/

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8813417 [details]
Bug 1319542 - Update RTCDataChannelInit to spec, and remove support for old deprecated values.

https://reviewboard.mozilla.org/r/94818/#review95340

::: dom/media/PeerConnection.js:1219
(Diff revision 1)
> -
> -    // Synchronous since it doesn't block.
> -    let channel = this._impl.createDataChannel(
> +    return this._impl.createDataChannel(label, protocol, type, ordered,
> +                                        maxPacketLifeTime, maxRetransmits,
> +                                        negotiated, id);

Probably leave the comment

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8813417 [details]
Bug 1319542 - Update RTCDataChannelInit to spec, and remove support for old deprecated values.

https://reviewboard.mozilla.org/r/94818/#review95344

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8813417 [details]
Bug 1319542 - Update RTCDataChannelInit to spec, and remove support for old deprecated values.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/94818/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1f8ed76c1e7
Update RTCDataChannelInit to spec, and remove support for old deprecated values. r=jesup,mrbkap

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f1f8ed76c1e7