Closed Bug 1319542 Opened 3 years ago Closed 3 years ago

Update pc.createDataChannel's RTCDataChannelInit dict to spec.

Categories

(Core :: WebRTC, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jib, Assigned: jib)

References

Details

Attachments

(1 file)

While cleaning up PeerConnection.js I'm finding various areas of neglect. createDataChannel is one.
Rank: 15
Priority: -- → P1
Comment on attachment 8813417 [details]
Bug 1319542 - Update RTCDataChannelInit to spec, and remove support for old deprecated values.

https://reviewboard.mozilla.org/r/94818/#review95340

::: dom/media/PeerConnection.js:1219
(Diff revision 1)
> -
> -    // Synchronous since it doesn't block.
> -    let channel = this._impl.createDataChannel(
> +    return this._impl.createDataChannel(label, protocol, type, ordered,
> +                                        maxPacketLifeTime, maxRetransmits,
> +                                        negotiated, id);

Probably leave the comment
Attachment #8813417 - Flags: review?(rjesup) → review+
Comment on attachment 8813417 [details]
Bug 1319542 - Update RTCDataChannelInit to spec, and remove support for old deprecated values.

https://reviewboard.mozilla.org/r/94818/#review95344
Attachment #8813417 - Flags: review?(mrbkap) → review+
Pushed by jbruaroey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1f8ed76c1e7
Update RTCDataChannelInit to spec, and remove support for old deprecated values. r=jesup,mrbkap
https://hg.mozilla.org/mozilla-central/rev/f1f8ed76c1e7
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Blocks: 1365081
Depends on: 1517731
You need to log in before you can comment on or make changes to this bug.